181106 - edit-multiple.html.tmpl uses &apos which Internet Explorer cannot use (patch included)

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Thomas Stromberg]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021112 Chimera/0.6+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.1) Gecko/20021112 Chimera/0.6+

In the "Don't change this group restriction" dialog, Bugzilla uses &apos instead
of the classic &#39 code for the apostrophe. This makes it literally print &apos
if you are using Internet Explorer 5.X



Reproducible: Always

Steps to Reproduce:
1. Get bug list
2. Change multiple tickets ..
3. See message

Comment 1

[Thomas Stromberg]

Attachment: edit-multiple.html.tmpl patch to change from &apos to &#39

Comment 2

[Dave Miller [:justdave]]

Is there a reason we can't just use a normal apostrophe in here instead of
having to make it an entity at all?  It's not inside an attribute or anything...

Comment 3

[Dave Miller [:justdave]]

Comment on attachment 106909 [details] [diff] [review]
edit-multiple.html.tmpl patch to change from &apos to &#39

HTML encoding issue...	Hixie, see comment 2 on this bug.

Comment 4

[Hixie (not reading bugmail)]

No reason that I can see, at any rate.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 106909 [details] [diff] [review]
edit-multiple.html.tmpl patch to change from &apos to &#39

ok, per comment 4, denying review.

We probably should get rid of the ', but let's make it an actual
apostrophe (') instead of '.

Comment 6

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 7

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 8

[Vlad Dascalu]

Per comment #5 above, this needs a patch, changing status from unconfirmed to new.

Comment 9

[Vlad Dascalu]

Resolving this. 
 
It has been fixed by this: 
 
07/03/2003 14:31 
gerv%gerv.net  
mozilla/ webtools/ bugzilla/ template/ en/ default/ list/ edit-multiple.html.tmpl  
1.12  
30/28   
Bug 13540 - allow key terms, like "Bugzilla" and "bug", to be altered without 
changing all the templates. Patch by [e-mail]; r=gerv, 
a=justdave.  
 
Diff available at 
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/webtools/bugzilla/template/en/default/list&command=DIFF_FRAMESET&file=edit-multiple.html.tmpl&rev1=1.11&rev2=1.12&root=/cvsroot 
. 

Comment 10

[Vlad Dascalu]

*** Bug 234011 has been marked as a duplicate of this bug. ***

Comment 11

[Vlad Dascalu]

Reopening per bug 234011. (we need it only for the 2.16 branch?)

Comment 12

[Christian Reis]

Errr.. well, the duped bug had a patch on it at least.

Comment 13

[Vlad Dascalu]

Sorry about that, can you repost it here? If you're short on time I can do that. :-)

Comment 14

[Vlad Dascalu]

Fixed on the tip, we need it for branch only per previous comments.

Comment 15

[Christian Reis]

I'm a bit crushed -- can you move it and get the reviews going? thanks :)

Comment 16

[Gervase Markham [:gerv]]

Attachment: Kiko's patch from bug 234011

Comment 17

[Gervase Markham [:gerv]]

Kiko: this one's yours to check in, right? Whenever suits you.

Gerv

Comment 18

[Christian Reis]

/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v
 <--  edit-multiple.html.tmpl
new revision: 1.4.2.3; previous revision: 1.4.2.2

The branch says "Thanks"!