1811229 - Fix reporting toolbox as a valid browsing context

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Alexandre Poirot [:ochameau]]

The following internal method:
https://searchfox.org/mozilla-central/rev/daf613efc5c358f3a94961d73b90472c00703838/devtools/server/actors/watcher/browsing-context-helpers.sys.mjs#343-370
Is iterating about browser[remote="true"] instead of browser[type="content"].
This causes to miss children browsing context which are loading documents in the parent process. This piece of code is meant to workaround the fact that BrowsingContext.children doesn't report children document loaded via <browser type="content"> elements (like tabs or devtools toolboxes).

This causes troubles in bug 1772822 as Storage Resource Watchers in the parent process aren't going through toolbox document.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1811229 - [devtools] Fix reporting toolbox as a valid browsing context

remote=true wasn't quite the right check here.
This workaround here is rather around chrome <=> content boundaries.
When we load a URL that loads in the parent process (like about:devtools-toolbox),
this ignores remote=true and loads in parent, but type="content"
is still enforced and still prevent it from being listed in BrowsingContext.children.

Because of this the about:devtools-toolbox wasn't visible in the storage panel.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e176fa050cfe
[devtools] Fix reporting toolbox as a valid browsing context r=devtools-reviewers,jdescottes

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/e176fa050cfe