1772822 - Enable all storage Watchers on the server for all target types

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement)

Description

[Alexandre Poirot [:ochameau]]

This is about toggling all the following traits to true:
https://searchfox.org/mozilla-central/rev/4c3f6e8bf87fffb7c62feb4c76a14e0eb0b94c1f/devtools/server/actors/watcher/session-context.js#206-207,209-211
And stop using the legacy listener for all the storage resources.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1772822 - [devtools] Enable server resource watcher for content-process storage types.

They should work out of the box as they filter by WindowGlobalTargetActor.windows
and this should be correct for the ParentProcesTargetActor.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1772822 - [devtools] Enable server resource watcher for parent-process storage types.

It looks like this is all filtered by getAllBrowsingContextsForContext and isWindowGlobalPartOfContext
so it should only process the expected window globals.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1772822 - [devtools] Fix reporting toolbox as a valid browsing context

remote=true wasn't quite the right check here.
This workaround here is rather around chrome <=> content boundaries.
When we load a URL that loads in the parent process (like about:devtools-toolbox),
this ignores remote=true and loads in parent, but type="content"
is still enforced and still prevent it from being listed in BrowsingContext.children.

Because of this the about:devtools-toolbox wasn't visible in the storage panel.

Comment 4

[Phabricator Automation]

Comment on attachment 9311940 [details]
Bug 1772822 - [devtools] Fix reporting toolbox as a valid browsing context

Revision D166659 was moved to bug 1811229. Setting attachment 9311940 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/853cc7a03c53
[devtools] Enable server resource watcher for content-process storage types. r=devtools-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/5bd4441b15bc
[devtools] Enable server resource watcher for parent-process storage types. r=jdescottes,nchevobbe,devtools-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/853cc7a03c53
https://hg.mozilla.org/mozilla-central/rev/5bd4441b15bc