1811542 - Change non SUMO links on about:preferences#privacy to use html:a elements instead of xul labels

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P3)

Description

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • There are a few "Learn more" links (or the "Privacy Notice" and maybe others) that don't fit the use case of the moz-support-link component. These exceptions on the about:preferences#privacy should instead use <html:a> elements instead.
     • List of exceptions by ID:
       • relayIntegrationLearnMoreLink
       • dataCollectionPrivacyNotice
       • FHRLearnMore
       • viewShieldStudies
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your changes. The links should navigate to the same locations as in Firefox Nightly. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 1

[eprendergast]

I am somewhat sure I can work on this, at least as long as I've understood this report correctly. So I will do some work on this.

Comment 2

[eprendergast]

Attachment: Bug 1811542 - Changed learnMore labels on non mozilla support links in Privacy settings to html:a elements r=tgiles

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02cc68ce9269
Changed learnMore labels on non mozilla support links in Privacy settings to html:a elements r=tgiles

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/02cc68ce9269