1920421 - Some Settings links open in the current about:preferences tab instead of a new tab

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Fix these Settings links to open in a new tab like Settings' other "Learn more" links:

• The "Learn more" link for "Suggest Firefox Relay email masks to protect your email address"
• The Privacy Notice link for "Firefox Data Collection and Use"
• The "Learn more" link for "Allow Firefox to send technical and interaction data to Mozilla"
• The "View Firefox Studies" (about:studies) link for "Allow Firefox to install and run studies"

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1920421 - Fix Settings links to open in a new tab. r?#settings-reviewers

1. Fix these Settings links to open in a new tab like Settings' other "Learn more" links:

• The "Learn more" link for "Suggest Firefox Relay email masks to protect your email address"

• The Privacy Notice link for "Firefox Data Collection and Use"

• The "Learn more" link for "Allow Firefox to send technical and interaction data to Mozilla"

• The "View Firefox Studies" (about:studies) link for "Allow Firefox to install and run studies"

2. Also remove a redundant target="_blank" in searchResults.inc.xhtml because the link's is="moz-support-link" attribute will cause the link to open in a new tab.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dd8febaaab7
Fix Settings links to open in a new tab. r=Gijs

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2dd8febaaab7