1812060 - Strip tab and newline from Location/URL/<a>/<area>'s protocol setter

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Anne (:annevk)]

Corrected tests: https://github.com/web-platform-tests/wpt/pull/38032.

Context: https://github.com/whatwg/url/issues/609.

Comment 1

[Oliver Medhurst [:canadahonk]]

I believe carriage returns (\r or \0x0D) should be removed as well, looking at WPT tests: https://github.com/web-platform-tests/wpt/blob/master/url/resources/setters_tests.json#L276

Comment 2

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1812060 - Strip certain whitespace from protocol setters

Strip tabs, new lines, and carriage returns from the input given to
protocol setters for Location, URL, and Link.

Reference: https://github.com/whatwg/url/issues/609

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b9cc90f1880
Strip certain whitespace from protocol setters r=emilio,necko-reviewers,valentin

Comment 4

[Iulian Moraru]

Backed out for causing wpt failures on url-setters-a-area.window.html.

• Push with failures

• Failure log
  Also, some times this crashes first and it's followed by the fail from the above link: https://treeherder.mozilla.org/logviewer?job_id=406582279&repo=autoland&lineNumber=35730
  LATER EDIT: there are also failures with this failure line TEST-UNEXPECTED-FAIL | /html/semantics/scripting-1/the-script-element/execution-timing/108.html | scheduler: javascript URL in iframe - assert_array_equals: expected property 2 to be "iframe script #1" but got "iframe script#1" (expected array ["inline script #1", "inline script #2", "iframe script #1"] got ["inline script #1", "inline script #2", "iframe script#1"])

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58a9faf47921
Strip certain whitespace from protocol setters r=emilio,necko-reviewers,valentin

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/58a9faf47921