Geolocation permission prompt looks broken when search term persistence is enabled
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
People
(Reporter: gregp, Assigned: jteow)
References
(Blocks 3 open bugs)
Details
Attachments
(2 files)
Steps to reproduce:
- Open Firefox Nightly
- Navigate to about:config
- Set
browser.urlbar.showSearchTerms.featureGate
totrue
- Set
browser.urlbar.showSearchTerms.enabled
totrue
- Enter a search term in the address bar
- Press enter
- Wait for Google to request access to your location (It's not clear to me how they decide to do this, it seems like a 50/50 chance each time).
- Alternatively, open developer tools
- Go to 'Console'
- Paste
document.documentElement.addEventListener("click", () => navigator.geolocation.getCurrentPosition(() => {}));
- Press enter
- Click anywhere on the page content
Expected results:
Geolocation permission prompt is anchored to the permission request button (like a normal webpage) or suppressed.
Actual results:
Geolocation prompt looks like its awkwardly anchored to the magnifying glass.
Assignee | ||
Comment 1•1 year ago
|
||
Thanks for pointing this out.
We might want to add some logic to revert back to the URL if we detect the Geolocation prompt has been triggered.
Assignee | ||
Comment 2•1 year ago
|
||
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 3•1 year ago
•
|
||
Escalating priority since this can cause major issue with other popups.
Updated•1 year ago
|
Pushed by jteow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f6889529519 Revert urlbar if a PopupNotification is about to be shown while search terms persist - r=adw,Gijs
Reporter | ||
Comment 5•1 year ago
|
||
You should consider adding telemetry for how often the SERP actually triggers this scenario. The utility of this feature may be greatly reduced if Google is constantly requesting geolocation access.
Assignee | ||
Comment 6•1 year ago
|
||
Very true, thanks for the feedback (and reminder) Gregory, we're scheduling that as a follow-up to prioritize a fix that was affecting a similar use-case.
Comment 7•1 year ago
|
||
bugherder |
Comment 8•1 year ago
|
||
Reproduced on a 2023-01-24 Nightly build on macOS 12.
Verified as fixed on Nightly 112.0a1(build ID: 20230214093302) on macOS 12, Ubuntu 22, Windows 10.
Updated•1 year ago
|
Comment 9•1 year ago
|
||
Reproduced on a 2023-01-24 Nightly build on macOS 12.
Verified as fixed on Firefox 111.0b3(build ID: 20230219190218) on macOS 12, Ubuntu 22, Windows 10.
Description
•