1812232 - Geolocation permission prompt looks broken when search term persistence is enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Gregory Pappas [:gregp]]

Attachment: geolocation_prompt.png

Steps to reproduce:

1. Open Firefox Nightly
2. Navigate to about:config
3. Set browser.urlbar.showSearchTerms.featureGate to true
4. Set browser.urlbar.showSearchTerms.enabled to true
5. Enter a search term in the address bar
6. Press enter
7. Wait for Google to request access to your location (It's not clear to me how they decide to do this, it seems like a 50/50 chance each time).
8. Alternatively, open developer tools
9. Go to 'Console'
10. Paste document.documentElement.addEventListener("click", () => navigator.geolocation.getCurrentPosition(() => {}));
11. Press enter
12. Click anywhere on the page content

Expected results:
Geolocation permission prompt is anchored to the permission request button (like a normal webpage) or suppressed.

Actual results:
Geolocation prompt looks like its awkwardly anchored to the magnifying glass.

Comment 1

[James Teow [:jteow]]

Thanks for pointing this out.

We might want to add some logic to revert back to the URL if we detect the Geolocation prompt has been triggered.

Comment 2

[James Teow [:jteow]]

Attachment: Bug 1812232 - Revert urlbar if a PopupNotification is about to be shown while search terms persist - r?adw

Comment 3

[James Teow [:jteow]]

Escalating priority since this can cause major issue with other popups.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f6889529519
Revert urlbar if a PopupNotification is about to be shown while search terms persist - r=adw,Gijs

Comment 5

[Gregory Pappas [:gregp]]

You should consider adding telemetry for how often the SERP actually triggers this scenario. The utility of this feature may be greatly reduced if Google is constantly requesting geolocation access.

Comment 6

[James Teow [:jteow]]

Very true, thanks for the feedback (and reminder) Gregory, we're scheduling that as a follow-up to prioritize a fix that was affecting a similar use-case.

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8f6889529519

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproduced on a 2023-01-24 Nightly build on macOS 12.
Verified as fixed on Nightly 112.0a1(build ID: 20230214093302) on macOS 12, Ubuntu 22, Windows 10.

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproduced on a 2023-01-24 Nightly build on macOS 12.
Verified as fixed on Firefox 111.0b3(build ID: 20230219190218) on macOS 12, Ubuntu 22, Windows 10.