18123 - [PP]File in use not replaced after install

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Jimmy Lee]

Build: 1999-11-05-08-M11(MAC)

1. From http://jimbob/trigger2.html, click drop-down menu and select
   f_addsubcomp_macsmpltxt
2. Click Trigger case button to install
3. From "Program" directory, open "simpletext_subdir" folder and launch Simple
   Text application
4. From Seamonkey, go to http://jimbob/trigger2.html, click drop-down menu and
   select f_addsubcomp_macsmpltxt_inus
5. Click Trigger case button to install

Install.StartInstall("Functional: f_addsubcomp_macsmpltxt_inus",
"f_addsubcomp_macsmpltxt", "1.0.1.5", 1);
f = Install.GetFolder("Program", "simpletext_subdir");
Install.AddSubcomponent(regName, "1.0.1.5", jarSrc, f, jarSrc, true);

RESULT:
When we attempt to install a file that is in use, the original file gets renamed
to "SimpleText-1".  The new file does not get installed.  The Install.log shows:

---------------------------------------------------------------------------
http://jimbob/jars/f_addsubcomp_macsmpltxt.jar  --  11/05/1999 13:24:54
---------------------------------------------------------------------------

     Functional: f_addsubcomp_macsmpltxt
     -----------------------------------

     Item [1/1]	Installing:
Webbies:moz115:mozilla-mac-M11:simpletext_subdir:SimpleText

     Install completed successfully
     Finished Installation  11/05/1999 13:24:59

---------------------------------------------------------------------------
http://jimbob/jars/f_addsubcomp_macsmpltxt_inus.jar  --  11/05/1999 13:26:21
---------------------------------------------------------------------------

     Functional: f_addsubcomp_macsmpltxt_inus
     ----------------------------------------

     Install **FAILED** with error -201

     Install **FAILED** with error -201
     Finished Installation  11/05/1999 13:26:26

EXPECTED RESULT:
No error message from the Install.log.  Quitting and restarting SimpleText
should reflect the second installation (126K).

Comment 1

[Daniel Veditz [:dveditz]]

Is this still a problem?

Comment 2

[Jimmy Lee]

1999-12-02-13-M12

I'll check this when Bug 19133 is fixed.  Currently, I'm blocked.

Comment 3

[Daniel Veditz [:dveditz]]

Samir, this depends on the project change and #ifndef removal in
xpfe/bootstrap/nsAppRunner.cpp you volunteered for. Need this in M12, should be
simple and not take much time.

Comment 4

[Samir Gehani]

That was checked in over the weekend so marking fixed.

Comment 5

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 6

[Jimmy Lee]

This is a dupe of Bug 6410.  This will be verified when 6410 is fixed.

Comment 7

[Jimmy Lee]

Build 1999-12-14-08-M12(MAC)

Fixed!