1812321 - The name of the device used is clipped instead of wrapped if the text excedes the limit of the microfone/camera site permission panel

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

Found in

• Latest Nightly 111.0a1

Affected versions

• Firefox 110.0b5
• Latest Nightly 111.0a1

Unaffected versions

• Firefox 109.0

Tested platforms

• Affected platforms: Windows 10, macOS 13 and Ubuntu 18.04.
• Unaffected platforms: none

Preconditions

• A device (camera or microphone) with a long name is required and connected to the PC/laptop.

Steps to reproduce

1. Visit a page that requires microphone and camera (eg. https://meet.jit.si/TesthingMicAndCameraForAFirefoxBug)

Expected result

• The name of the device is wrapped if too long using elipses.

Actual result

• The name of the device used is clipped

Regression range

• First bad: 47c002d3637247e71ee901f32421deaecc9d8ea3
• Last good: 0c989b2bcd7882a9e7106e7879ab8933c2e09071
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c989b2bcd7882a9e7106e7879ab8933c2e09071&tochange=47c002d3637247e71ee901f32421deaecc9d8ea3
• Potentially regressed by: Bug 1805414 - Remove nsMenuFrame

Additional notes

• Not entirely sure if this issue should end up in Site permission component or here in menus. Please change it accordingly if necessary.
• By clipping the name of the device the little icon showing the type of permission (mic or cam) is removed as well.
• Not sure if other site permission panels are affected by this, not sure which one could also display a long text inside the dropdown.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=Itiel,dao,Gijs

This was mixing old and new flexbox in a way that it happened to work
before my patch, but really should've always needed min-width to work.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08f5c59b7ba4
Preserve shrinking behavior of webrtc device selector. r=dao

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/08f5c59b7ba4

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9314154 [details]
Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=Itiel,dao,Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial, targeted css fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9314154 [details]
Bug 1812321 - Preserve shrinking behavior of webrtc device selector. r=Itiel,dao,Gijs

Approved for our last 110 beta, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/22a6f6f5023f

Comment 8

[Bogdan Maris, Desktop QA]

Verified that using latest Nightly 111.0a1 and latest Beta (from treeherder) across platforms (Windows 10, Ubuntu 18.04 and macOS 13) this is now fixed.