1812445 - Checkbox and label for private browsing permissions are displayed on different lines in post-install dialog

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P2)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot, Italian build

I can reproduce it on Nightly, but also on older build (108). It works correctly on ESR 102.

I assume this happens when the localized text is longer than English, but it might be reproducible with pseudolocale.

Comment 1

[Itiel]

Regressed by bug 1790616

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790616

:emilio, since you are the author of the regressor, bug 1790616, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=Itiel,dao

Why was it there? Who knows?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a723f60b567
Remove declaration that didn't use to have an effect before flexbox emulation. r=dao

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7a723f60b567

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9314143 [details]
Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=Itiel,dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9314143 [details]
Bug 1812445 - Remove declaration that didn't use to have an effect before flexbox emulation. r=Itiel,dao

Approved for our last 110 beta, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/fac39bc41f50

Comment 10

[Alex Cornestean]

Verified as Fixed on the latest Nightly (111.0a1/20230201215112). Tested on Windows 10 x64 and macOS 11.3.1.

The checkbox and string are now displayed on the same line, confirming the fix. For more details, see the attached screenshot.

Comment 11

[Alex Cornestean]

Attachment: 2023-02-02_10h35_41.png

Comment 12

[Alex Cornestean]

Verified as Fixed on the latest Beta (110.0b9/20230202190127). Tested on Windows 10 x64 and macOS 11.3.1.

The checkbox and string are now displayed on the same line, confirming the fix. For more details, see the attached screenshot.

Comment 13

[Alex Cornestean]

Attachment: 2023-02-03_07h58_50.png