1812672 - Glean RLB v52.1.0 seems to be broken on Windows

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Beatriz Rizental [:brizental]]

The update to whatsys 0.3.0 is a breaking change but the required code changes seem not to have been made.

Here is the error we are seeing:

error[E0425]: cannot find function `get_windows_build_number` in crate `whatsys`
[task 2023-01-26T15:41:34.808Z]   --> Z:\task_167474710947847\build\src\3rdparty\glean\glean-core\rlb\src\system.rs:79:20
[task 2023-01-26T15:41:34.808Z]    |
[task 2023-01-26T15:41:34.808Z] 79 |     match whatsys::get_windows_build_number() {
[task 2023-01-26T15:41:34.808Z]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `windows_build_number`
[task 2023-01-26T15:41:34.808Z]    |
[task 2023-01-26T15:41:34.808Z]   ::: Z:/task_167474710947847/cmake_build/cargo_home\registry\src\github.com-1ecc6299db9ec823\whatsys-0.3.0\src\windows.rs:44:1
[task 2023-01-26T15:41:34.808Z]    |
[task 2023-01-26T15:41:34.808Z] 44 | pub fn windows_build_number() -> Option<i32> {
[task 2023-01-26T15:41:34.808Z]    | -------------------------------------------- similarly named function `windows_build_number` defined here

Comment 1

[Travis Long [:travis_]]

Whoops, not sure how this slipped by. Sorry about that, we will get this fixed up quickly.

Comment 2

[Perry McManis [:perry.mcmanis]]

Attachment: GitHub Pull Request

Comment 3

[Perry McManis [:perry.mcmanis]]

thanks for the heads up [:brizental], I cut 52.1.1 to address this:

https://github.com/mozilla/glean/releases/tag/v52.1.1

Comment 4

[Beatriz Rizental [:brizental]]

Thanks for the super quick fix folks :D