1812732 - Empty collection can be created

Status: VERIFIED FIXED

(Fenix :: Collections, defect, P3)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/20391.

Steps to reproduce

1. Open a tab
2. Tap the ⋮ "More options button"
3. Tap "Select tabs" from the menu
4. Tap the "Add new collection" button
5. Confirm the collection creation
6. Tap "View" from the confirmation snackbar

Expected behaviour

• Shouldn't be able to create empty collection

Actual behaviour

• Empty collection is created

Device name

• OnePlus A3 (Android 6.0.1)

Firefox version

• Nightly 92.0a1
• Beta 91.0.0-beta.1

Additional information

► Video

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[happinessmncube]

Is a solution of making the Add new collection button unclickable a good option in this case?

Comment 2

[Chris Peterson [:cpeterson]]

I can no longer reproduce this bug. The steps to reproduce in comment 0 mention a "More options button" menu item that no longer exists, so I tried the alternate steps in this GitHub comment:

https://github.com/mozilla-mobile/fenix/issues/20391#issuecomment-951974654

1. Have no collections created yet and at least one tab open
2. Open the homepage
3. Tap the "Save tabs to collection" button
4. Tap the "Add new collection" button
5. Tap ok

And I still wasn't able to create an empty collection. When no tabs are selected, the + button is not shown.

Comment 3

[Adina Petridean QA [:apetridean]]

The issue can be reproduced in the latest Nightly 113.0a1 from 15/03, with Firefox 112.0b2 and also with Firefox 111.0 by following Chris Peterson's steps, as well as the following steps:

1. Have no collections created yet and at least one tab open
2. Open the tabs tray.
3. Tap the 3dot menu button.
4. Tap the "Select tabs" button.
5. Tap the "Save tabs to collection" button
6. Tap the "OK" button from Add new collection prompt.

Device used : Google Pixel 3 XL (Android 9)

Comment 4

[Adina Petridean QA [:apetridean]]

Attachment: Collection.mov

Comment 5

[happinessmncube]

In this case is a solution of making the Add new collection button unclickable a good option in this case?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to happinessmncube from comment #5)

In this case is a solution of making the Add new collection button unclickable a good option in this case?

I need to ask the UI designers to review your proposed solution. They have a long backlog of work, so that might take a couple weeks.

In the meantime, I recommend looking at Android good-first-bugs on "Codetribute" that don't require UI changes:

https://codetribute.mozilla.org/projects/fenix

Comment 7

[BMO Github Automation]

Authored by https://github.com/gitstart
https://github.com/mozilla-mobile/firefox-android/commit/64ccd3659704c7776877a3c2454273d07a57df23
[main] Bug 1812732 - Empty collection can be created

Comment 8

[Lorand Janos]

Verified as fixed on the latest Nightly 116.0a1 (2023-06-12T15:13:07.558982) build.
After tapping on "Select tabs" from the menu, the "Add new collection" button is not active.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified for 116.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift request?

Comment 10

[Jeff Boek [:boek]]

I don't think so. But I will verify with Product

Comment 11

[twhite]

Attachment: GitHub Pull Request

Comment 12

[Jeff Boek [:boek]]

Does not need an uplift

Comment 13

[Lorand Janos]

This issue is again reproducible from 121.

Tested devices: Samsung Galaxy S23 Ultra (Android 13) and Google Pixel 7 (Android 14).

Tested builds:

• latest RC 120.0 build 2 (Not reproducible).
• latest Beta 121.0b2.
• latest Nightly 122.0a1 from 2023-11-23.

Reopening the ticket.

Comment 14

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812732 - Prevent empty Collection being created in Compose Tabs Tray (#4606)

Comment 15

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/8782fcd036f547badca94eaddc6ff342d47a7eb6
[main] Bug 1812732 - Prevent empty Collection being created in Compose Tabs Tray

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:towhite, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 17

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812732 - Prevent empty Collection being created in Compose Tabs Tray (backport #4606) (#4623)

Comment 18

[twhite]

Comment on attachment 9365840 [details] [review]
[mozilla-mobile/firefox-android] Bug 1812732 - Prevent empty Collection being created in Compose Tabs Tray (backport #4606) (#4623)

Beta/Release Uplift Approval Request

• User impact if declined: User can create an empty Collection
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes during PR, no QA yet
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. Open Tabs
2. 3 button menu
3. Press 'Select tabs'
4. Do not select any tabs
5. Press the Collections button

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor change easily verifiable
• String changes made/needed:
• Is Android affected?: No

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365840 [details] [review]
[mozilla-mobile/firefox-android] Bug 1812732 - Prevent empty Collection being created in Compose Tabs Tray (backport #4606) (#4623)

Approved for 121.0b5.

Comment 20

[BMO Github Automation]

Authored by https://github.com/t-p-white
https://github.com/mozilla-mobile/firefox-android/commit/bf094bac0cee1855cc12ec5d9bc67090cbab7e1b
[releases_v121] Bug 1812732 - Prevent empty Collection being created in Compose Tabs Tray

Comment 21

[Lorand Janos]

Verified as fixed on the latest Nightly build (122.0a1 from 2023-11-29).

Tested using the same steps I reproduced it with a few days ago.

Device used: Samsung Galaxy S23 Ultra (Android 13).

Marking the ticket as verified on 122.

Comment 22

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox 121.0b6
Device used: Samsung Galaxy S23 Ultra (Android 13) and Tab: Sony Xperia (Android 6.0.1).