1837006 - Disable the 'add to collection' button when no tabs are selected

Status: RESOLVED DUPLICATE of bug 1866990

(Firefox for Android :: Tabs, defect, P5)

Description

[twhite]

Attachment: Screenshot 2023-06-06 at 17.01.54.png

Follow existing 'disabled' icon designs.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1837006 - Make the add to collection button follow existing disabled icon designs when disabled (#2476)

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:007, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Noah Bond [:007]]

Hey :twhite, is this an ask from UX or is this something you filed yourself? If it's the latter, this should be ran past UX and we'll need a corresponding patch for the Compose rewrite.

Tangentially, I'd assume the share button would need similar treatment.

I've added a "do not land" label to the PR for the time being.

Comment 4

[twhite]

Hey [:007], I created this bug following this bug. UX are tagged in the whiteboard section so I'm assuming it should reach their visibility at some point. Good point about the 'share button', yes I think that would also benefit following the same behaviour.

Comment 5

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:007, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Noah Bond [:007]]

A fix for this (from Alex!) landed this week!