1812840 - "Firefox Suggest" header disappears when I focus the menu entry right below it

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Start Firefox with a fresh profile.
2. Type "moz" into the URL bar. This should give you a few Firefox Suggest awesomebar-suggestions.
3. Use downarrow to focus the first suggestion under the "Firefox Suggest" header.

ACTUAL RESULTS:
The "Firefox Suggest" header disappears when that first suggestion is focused. It reappears if you focus another suggestion further down.

EXPECTED RESULTS:
Firefox Suggest header shouldn't disappear.

I'm using Firefox Nightly 111.0a1 (2023-01-26) (64-bit)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast

Comment 2

[Daniel Holbert [:dholbert]]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6b9c280f186bdf9338b45df9047465b80008c33d&tochange=95efc81f5d0da6252772c8a344388de3df68001e

--> regression from bug 1801297

Comment 3

[Mehmet]

Attachment: demo.mov

I can't reproduce this with Nightly 111.0a1 (2023-01-26) (64-Bit) on macOS 12.6.3.

But what I am seeing is, that the Header Title is changing the brightness when selecting the first result below it. But only with the Alpenglow Theme. Not with the dark or light theme.

Not sure if this is related to your bug?

A demo is attached.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1801297

:dao, since you are the author of the regressor, bug 1801297, could you take a look?

For more information, please visit auto_nag documentation.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Mehmet from comment #3)

Created attachment 9314405 [details]
demo.mov

I can't reproduce this with Nightly 111.0a1 (2023-01-26) (64-Bit) on macOS 12.6.3.

But what I am seeing is, that the Header Title is changing the brightness when selecting the first result below it. But only with the Alpenglow Theme. Not with the dark or light theme.

Not sure if this is related to your bug?

A demo is attached.

Same here. Can't reproduce the original bug but I do see the label color changing.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1812840 - Fix group label color. r=adw

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46cbec2bed6a
Fix group label color. r=adw

Comment 8

[Daniel Holbert [:dholbert]]

(In reply to Mehmet from comment #3)

I can't reproduce this with Nightly 111.0a1 (2023-01-26) (64-Bit) on macOS 12.6.3.

But what I am seeing is, that the Header Title is changing the brightness when selecting the first result below it. But only with the Alpenglow Theme. Not with the dark or light theme.

Like you, I can't repro on macOS, but I do see the alpenglow highlight thing, and that seems likely to be a manifestation of the same issue.

When I filed this, I was using Ubuntu 22.04. In further testing, I've found that this only repro's for me with these settings:

• In Ubuntu Settings-app, Appearance section: must be "Style: Light"
• In Firefox Add-ons/theme page: theme must be "Default" (which has a "light" look, given my Ubuntu appearance settings)

I can't reproduce the disappearing-text-bug (or anything like it) if I explicitly activate the Firefox "Light" or "Dark" themes.
I also can't reproduce any issues if I activate Ubuntu's "Dark" appearance (regardless of whether I choose Firefox Default or Light or Dark themes).

Comment 9

[Daniel Holbert [:dholbert]]

This suggests to me that this bug might really be revealing that one of our foreground-color-variables (whichever one we were using here) might be mistakenly the wrong value, specifically under the default theme with Ubuntu Appearance Settings "Style:Light"...

[EDIT: Good news, turns out this is mostly fine. See notes in comment 11 for how we end up with mismatching foreground/background colors here.]

Comment 10

[Daniel Holbert [:dholbert]]

Aha -- so, using Browser Toolbox in current Nightly (which doesn't yet have comment 7's patch), I can see that this text has:
color: var(--autocomplete-popup-highlight-color);
whfrom this rule:
https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/browser/themes/shared/urlbarView.css#228-230

.urlbarView-row:not([type=tip], [type=dynamic])[selected] {
  background-color: var(--autocomplete-popup-highlight-background);
  color: var(--autocomplete-popup-highlight-color);

This is an alias for SelectedItem and SelectedItemText (which are orange and white in my theme, as you can see in my screencast -- selected items have an orange background and white text).

The problem here is that this ::before pseudo-element is a child of a selected item (it's literally a child of the row directly below it) so it inherits color (since color inherits by default) but it does not inherit the background-color since background-color doesn't inherit by default.

Comment 11

[Daniel Holbert [:dholbert]]

So my Ubuntu default-theme and Alpenglow are both specially-able-to-reproduce-this because their SelectedItemText is different from the default text color.

I was worried that maybe we had some CSS rule that was specifying this as a color without specifying the proper/contrasting background-color -- but fortunately we're OK on that front -- we do correctly specify the proper contrasting background color in the relevant rule (quoted in comment 10). The issue was just that this color: ...; background-color: ... combination doesn't account for the possibility of having a descendant which inherits our color but is positioned over a different background area (as this group header is, via position:absolute; top: calc(-1.27em - 2px);)

So that's how we got into trouble here.

Anyway -- manually setting color on the group header to the value-that-we-would-be-inheriting-when-our-parent-isn't-focused (as Dão's patch does) seems like it does address this problem and avoids the issue.

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/46cbec2bed6a

Comment 13

[Mehmet]

The report-part with label color changing issue with the Alpenglow Theme is fixed for me now in 111.0a1 (2023-01-29) (64-Bit). Thanks for fixing it.

Comment 14

[Cristian Baica [:cbaica], Release Desktop QA]

I've managed to reproduce the issue using Firefox Nightly 111.0a1 (2023-01-26).
The issue is verified fixed using the latest Fx 111.0a1 on Ubuntu 22.04. The Firefox Suggest label no longer disappears when navigating with the keyboard in the section.
The issue with the Alpenglown theme no longer occurs. The label no longer changes color.