181302 - mailnews/mime/src/mimemdig.cpp:49 (See build log excerpt) Unused variable `struct MimeObjectClass * oclass'

Status: VERIFIED WORKSFORME

(MailNews Core :: MIME, defect)

Description

[timeless]

25. mailnews/mime/src/mimemdig.cpp:49 (See build log excerpt)
Unused variable `struct MimeObjectClass * oclass'

47 MimeMultipartDigestClassInitialize(MimeMultipartDigestClass *clazz)
48 {
49   MimeObjectClass    *oclass = (MimeObjectClass *)    clazz;
50   MimeMultipartClass *mclass = (MimeMultipartClass *) clazz;
51   PR_ASSERT(!oclass->class_initialized);

Comment 1

[Serge Gautherie (:sgautherie)]

Updating:
*(S) New -> "WorksForMe", since line 51 was using it :-<
 (unless PR_ASSERT was "hiding" its use !?)


The code has since become:
{
 46 static int
 47 MimeMultipartDigestClassInitialize(MimeMultipartDigestClass *clazz)
 48 {
 49 #ifdef DEBUG  
 50   MimeObjectClass    *oclass = (MimeObjectClass *)    clazz;
 51   PR_ASSERT(!oclass->class_initialized);
 52 #endif
 53   MimeMultipartClass *mclass = (MimeMultipartClass *) clazz;
 54   mclass->default_part_type = MESSAGE_RFC822;
 55   return 0;
 56 }
}

Comment 2

[timeless]

PR_ASSERT uses it, but only in debug builds, hence the ifdef fixes the problem.

Comment 3

[Serge Gautherie (:sgautherie)]

The fix to this was v1.5 :-)