90906 - Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call")

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Pete Collins (MDG)]

I am going to go and fix all of the "unused variable" compiler warnings i see
when building mozilla. We all want to have prestine compiler output when
building mozilla, so this is a step to help get there.

Feel free to change component, i set xpcom for lack of a better place to put
this bug. 

Assigning to myself.

Thanks

--pete

Comment 1

[Pete Collins (MDG)]

Assigning to myself . . .

Comment 2

[Pete Collins (MDG)]

Attachment: (Av1) </xpcom/*>

Comment 3

[Pete Collins (MDG)]

Attachment: (Bv1) </content/*>

Comment 4

[Kathleen :Brade]

I'm concerned about the content patch in "nsHTMLInputElement.cpp"  Are you sure 
the fix there isn't to just check the return value?

Comment 5

[Pete Collins (MDG)]

Yea, thanks for catching that Cathy. I beleive whoever authored that method,
probably menant to return if it fails.

Updating patch. 

--pete

Comment 6

[Pete Collins (MDG)]

Attachment: (Bv1b) </content/*>

Comment 7

[Kathleen :Brade]

the patch for xpcom is incomplete.  On Mac, I see these unused variables as well:
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/typelib/xpidl/
xpidl_java.c&mark=565#555
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/typelib/xpidl/
xpidl_idl.c&mark=314#304

Comment 8

[Kathleen :Brade]

also in xpcom, I see these in the logs on tinderbox:
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/tests/
nsIFileEnumerator.cpp&mark=19#9
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpcom/io/
nsAppFileLocationProvider.cpp&mark=326#316

and these in content:
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/xbl/src/
nsXBLBinding.cpp&mark=92#82
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/base/src/
nsStyleContext.cpp&mark=120#110

Comment 9

[Pete Collins (MDG)]

Attachment: (Cv1) </layout/*>

Comment 10

[Pete Collins (MDG)]

Attachment: (Dv1) </editor/*>

Comment 11

[Pete Collins (MDG)]

Attachment: (Ev1) </xpfe/*>

Comment 12

[Pete Collins (MDG)]

Attachment: (Fv1) </rdf/*>

Comment 13

[Pete Collins (MDG)]

Attachment: (Gv1) </mailnews/*>

Comment 14

[Pete Collins (MDG)]

Attachment: (Av1b) </xpcom/*>

Comment 15

[Pete Collins (MDG)]

pushing back

Comment 16

[Pete Collins (MDG)]

pushing back

Comment 17

[Serge Gautherie (:sgautherie)]

Updating:
*(C) XPCOM -> Browser-General
*(OS) other -> All

Comment 18

[Serge Gautherie (:sgautherie)]

Attachment: (Hv1) "Unused variable `[...]'"

Let's process this 2003-12-14 (H) patch;

then I'll check the 2001-07-1x (A-G) patchs,
to see if there are fixes to retrieve from them,
before marking them as 'obsolete'...

*****

Hv1 patch also does 2 little code rewrites;
and removes 3 |#ifdef notdef| blocks.

Advise needed:
*<nsCommandHandler.cpp>: remove |#include "nsWebBrowser.h"| too ??

Comment 19

[Serge Gautherie (:sgautherie)]

Comment on attachment 137382 [details] [diff] [review]
(Hv1) "Unused variable `[...]'"

'r=?': (see comment 18)
Can you (super-)review, compile, test, check it in ?

Comment 20

[Serge Gautherie (:sgautherie)]

I'm posting patches based on
<http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey>
'Linux brad Clbr', "Warn:____" link.

Comment 21

[Serge Gautherie (:sgautherie)]

Well, it seems that quite a number of more recent patchs were already around:
Nevertheless, I stand by what I wrote in comment 18: "Hv1 patch first ...".

Comment 22

[Brendan Eich [:brendan]]

Serge, please ask for individual module owners and peers to review their own
patches.  I'm not your compile, test, and check-in slave, either.  Ideally,
owners will check in good patches you submit.  If you can't get an owner to
respond, let me know.

/be

Comment 23

[Serge Gautherie (:sgautherie)]

Comment on attachment 137382 [details] [diff] [review]
(Hv1) "Unused variable `[...]'"

Re comment 22:

I'll split this global patch back to individual "modules".

As for compile/++, I'm not looking for any slave:
I only happen to have no compilation environment;

so I'm simply asking for help there:
I hope the rewievers (or anyone) will be able to do it "for me"...

Comment 24

[Serge Gautherie (:sgautherie)]

Attachment: (Av1c) </xpcom/*> [Checked in: Comment 83]

Comment 25

[Serge Gautherie (:sgautherie)]

Comment on attachment 137533 [details] [diff] [review]
(Av1c) </xpcom/*>
[Checked in: Comment 83]


'r=?': (see comment 23)

Comment 26

[Serge Gautherie (:sgautherie)]

Comment on attachment 42510 [details] [diff] [review]
(Bv1b) </content/*>


Obsoleting: nothing left to fix :->

Comment 27

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1b) </layout/*> [Checked in: Comment 73]

Comment 28

[Serge Gautherie (:sgautherie)]

Comment on attachment 137539 [details] [diff] [review]
(Cv1b) </layout/*>
[Checked in: Comment 73]


'r=?': (see comment 23)

Comment 29

[Serge Gautherie (:sgautherie)]

Comment on attachment 42611 [details] [diff] [review]
(Dv1) </editor/*>


Obsoleting: nothing left to fix :->

Comment 30

[Serge Gautherie (:sgautherie)]

Comment on attachment 42647 [details] [diff] [review]
(Ev1) </xpfe/*>


Obsoleting: nothing left to fix :->

Comment 31

[Serge Gautherie (:sgautherie)]

Comment on attachment 42649 [details] [diff] [review]
(Fv1) </rdf/*>


Obsoleting: nothing left to fix :->

Comment 32

[Serge Gautherie (:sgautherie)]

Attachment: (Gv1b) </mailnews/*> [Checked in: Comment 80]

Comment 33

[Serge Gautherie (:sgautherie)]

Comment on attachment 137544 [details] [diff] [review]
(Gv1b) </mailnews/*>
[Checked in: Comment 80]


'r=?': (see comment 23)

Comment 34

[Serge Gautherie (:sgautherie)]

Attachment: (Iv1) </xpinstall/*>

Comment 35

[Serge Gautherie (:sgautherie)]

Comment on attachment 137545 [details] [diff] [review]
(Iv1) </xpinstall/*>


'r=?': (see comment 23)

Note:
"review requestee: dveditz#cruzio.com  did not match anything";
<http://www.mozilla.org/owners.html> needs update to 'dveditz+bmo#cruzio.com' !

Comment 36

[Serge Gautherie (:sgautherie)]

Comment on attachment 137539 [details] [diff] [review]
(Cv1b) </layout/*>
[Checked in: Comment 73]


'approval1.6=?': Trivial unused code removal.
(if not too late)

Comment 37

[Serge Gautherie (:sgautherie)]

Attachment: (Jv1) </security/*>

Comment 38

[Serge Gautherie (:sgautherie)]

Comment on attachment 137547 [details] [diff] [review]
(Jv1) </security/*>


Removes 2 |#ifdef notdef| blocks too.

'r=?': (see comment 23)

Comment 39

[Serge Gautherie (:sgautherie)]

Attachment: (Kv1) </netwerk/*>

Comment 40

[Serge Gautherie (:sgautherie)]

Comment on attachment 137548 [details] [diff] [review]
(Kv1) </netwerk/*>


'r=?': (see comment 23)

Comment 41

[Serge Gautherie (:sgautherie)]

Attachment: (Lv1) </widget/src/mac/*> (cleanup only) [Checked in: Comment 78]

Comment 42

[Serge Gautherie (:sgautherie)]

Comment on attachment 137549 [details] [diff] [review]
(Lv1) </widget/src/mac/*> (cleanup only)
[Checked in: Comment 78]


(not this bug, but related to "(Jv1) </security/*>" cleanup)

Removes 1 |#ifdef notdef| blocks.

'r=?': (see comment 23)

Comment 43

[Serge Gautherie (:sgautherie)]

Attachment: (Mv1) </embedding/*> [Checked in: Comment 74]

Comment 44

[Serge Gautherie (:sgautherie)]

Comment on attachment 137550 [details] [diff] [review]
(Mv1) </embedding/*>
[Checked in: Comment 74]


Advise needed:
Is |#include "nsWebBrowser.h"| removable now ??

'r=?': (see comment 23)

Comment 45

[Serge Gautherie (:sgautherie)]

Attachment: (Nv1) </modules/libutil/*> [Checked in: Comment 72]

Comment 46

[Serge Gautherie (:sgautherie)]

Comment on attachment 137551 [details] [diff] [review]
(Nv1) </modules/libutil/*>
[Checked in: Comment 72]


(Chose you, as you r/sr the last patch to this file.)

'r=?': (see comment 23)

Note:
"review requestee: roc+#cs.cmu.edu  did not match anything";
<http://www.mozilla.org/owners.html> needs update to 'roc#ocallahan.org' !

Comment 47

[Serge Gautherie (:sgautherie)]

Reassigning from 'petejc#optonline.net' to me :->
(since last post was 2001-12-15: thanks anyway !)

Updating:
*(P) P3 -> --
*(S) normal -> trivial
*(TM) Future -> mozilla1.7alpha

Comment 48

[Serge Gautherie (:sgautherie)]

Attachment: (Iv1b) </xpinstall/*>

Patch Iv1, plus 2 unneeded initialization removals.

Comment 49

[Serge Gautherie (:sgautherie)]

Comment on attachment 137553 [details] [diff] [review]
(Iv1b) </xpinstall/*>


'r=?': (see comment 23)

Comment 50

[Serge Gautherie (:sgautherie)]

*** Bug 223729 has been marked as a duplicate of this bug. ***

Comment 51

[Serge Gautherie (:sgautherie)]

*** Bug 221132 has been marked as a duplicate of this bug. ***

Comment 52

[timeless]

please do things the way i did them.

Comment 53

[Serge Gautherie (:sgautherie)]

{ (result of a private email)
550 5.1.1 <timeless#bemail.org>... User unknown


Reporting-MTA: dns; mailrecv3.bigmailbox.com
Received-From-MTA: DNS; nan-smtp-13.noos.net
Arrival-Date: Wed, 17 Dec 2003 05:49:00 -0800

Final-Recipient: RFC822; timeless#bemail.org
X-Actual-Recipient: RFC822; timeless#mailrecv3.bigmailbox.com
Action: failed
Status: 5.1.1
Diagnostic-Code: X-Unix; 67
Last-Attempt-Date: Wed, 17 Dec 2003 05:49:07 -0800
}


> please do things the way i did them.

I will:
let me first ask you why you did it your way (for my learning process).

<http://bugzilla.mozilla.org/show_bug.cgi?id=221132>
What is the use of the (3-4) |#ifdef notdef| blocks ?

<http://bugzilla.mozilla.org/show_bug.cgi?id=223729>
Does not the localization inside the |do{...}| makes repetitive (de)allocations ?

Thanks.

Comment 54

[timeless]

if the compiler really sucks then it might do something silly with the loop,
but... local variables aren't allocated in memory the way that things are when
you do |malloc| or |new|. by telling the compiler that you're only using a
variable in some block, it is more likely to be able to reuse the address it
gives to the variable outside the block (a sucky compiler might not, but...).

for one, that code is not ours, nss has reasons for doing things, it isn't for
us to remove stuff from their code. it's true that you can rely on cvs to find
the code, but it's a royal pain. let me tell you, as i had to use it to answer
all the other questions you asked me yesterday.

you can contact me on irc or by using the realname field. (normally you can copy
that, but i'm traveling so you would have to remove that at the moment.)

Comment 55

[Serge Gautherie (:sgautherie)]

Attachment: (Iv1c) </xpinstall/*> [Checked in: Comment 71]

Patch Iv1b, plus a few variable localizations.

Comment 56

[Serge Gautherie (:sgautherie)]

Comment on attachment 137586 [details] [diff] [review]
(Iv1c) </xpinstall/*>
[Checked in: Comment 71]

'r=?': (see comment 23)

Comment 57

[Serge Gautherie (:sgautherie)]

Attachment: (Jv1b) </security/*> [+/- Checked in: see Comment 76]

Patch Jv1, plus restoration of 2 |#ifdef notdef| blocks. (To let NSS peoples
handle them.)

Comment 58

[Serge Gautherie (:sgautherie)]

Comment on attachment 137588 [details] [diff] [review]
(Jv1b) </security/*>
[+/- Checked in: see Comment 76]


'r=?': (see comment 23)

Comment 59

[Serge Gautherie (:sgautherie)]

Comment on attachment 137548 [details] [diff] [review]
(Kv1) </netwerk/*>


This will be included in bug 203422 patch :->

Comment 60

[Daniel Veditz [:dveditz]]

Comment on attachment 137586 [details] [diff] [review]
(Iv1c) </xpinstall/*>
[Checked in: Comment 71]

Seems like a lot of gratuitous moving variables around to get rid of one
warning, but OK if it makes you happy. sr=dveditz

Comment 61

[Serge Gautherie (:sgautherie)]

Comment on attachment 137586 [details] [diff] [review]
(Iv1c) </xpinstall/*>
[Checked in: Comment 71]

(For the record)

> gratuitous moving variables

1 was requested by timeless (from a duplicate bug): I simply applied it to 4
other occurences...

Comment 62

[Serge Gautherie (:sgautherie)]

Comment on attachment 137551 [details] [diff] [review]
(Nv1) </modules/libutil/*>
[Checked in: Comment 72]


'approval1.6=?': Trivial code move
(if not too late)

Comment 63

[tor]

Comment on attachment 137539 [details] [diff] [review]
(Cv1b) </layout/*>
[Checked in: Comment 73]

Too late in the 1.6 timeframe for changes that aren't serious
regressions, security, or crash related.

Comment 64

[tor]

Comment on attachment 137551 [details] [diff] [review]
(Nv1) </modules/libutil/*>
[Checked in: Comment 72]

Too late in the 1.6 timeframe for changes that aren't serious
regressions, security, or crash related.

Comment 65

[tor]

Comment on attachment 137586 [details] [diff] [review]
(Iv1c) </xpinstall/*>
[Checked in: Comment 71]

Too late in the 1.6 timeframe for changes that aren't serious
regressions, security, or crash related.

Comment 66

[Serge Gautherie (:sgautherie)]

Comment on attachment 137588 [details] [diff] [review]
(Jv1b) </security/*>
[+/- Checked in: see Comment 76]


'r=?': (see comment 23)
(moving from kaie to wchang)

Comment 67

[Serge Gautherie (:sgautherie)]

Comment on attachment 137544 [details] [diff] [review]
(Gv1b) </mailnews/*>
[Checked in: Comment 80]


'r=?': (see comment 23)
(moving sspitzer from r? to sr?)

Comment 68

[[e-mail]]

Comment on attachment 137544 [details] [diff] [review]
(Gv1b) </mailnews/*>
[Checked in: Comment 80]

I still don't like those trailing blank line deletions :-P

Comment 69

[Adam Lock]

Comment on attachment 137550 [details] [diff] [review]
(Mv1) </embedding/*>
[Checked in: Comment 74]

r=adamlock

Comment 70

[Alec Flett]

Comment on attachment 137550 [details] [diff] [review]
(Mv1) </embedding/*>
[Checked in: Comment 74]

sr=alecf

Comment 71

[Serge Gautherie (:sgautherie)]

Comment on attachment 137586 [details] [diff] [review]
(Iv1c) </xpinstall/*>
[Checked in: Comment 71]


Check in: { 12/20/2003 10:11	neil%parkwaycc.co.uk	1.17 }

Comment 72

[Serge Gautherie (:sgautherie)]

Comment on attachment 137551 [details] [diff] [review]
(Nv1) </modules/libutil/*>
[Checked in: Comment 72]


Check in: { 12/20/2003 10:10	neil%parkwaycc.co.uk	1.20 }

Comment 73

[Serge Gautherie (:sgautherie)]

Comment on attachment 137539 [details] [diff] [review]
(Cv1b) </layout/*>
[Checked in: Comment 73]


Check in: { 12/20/2003 10:09	neil%parkwaycc.co.uk }

Comment 74

[Serge Gautherie (:sgautherie)]

Comment on attachment 137550 [details] [diff] [review]
(Mv1) </embedding/*>
[Checked in: Comment 74]


Check in: { 12/20/2003 12:09	neil%parkwaycc.co.uk	1.7 }

Comment 75

[Wan-Teh Chang]

Comment on attachment 137588 [details] [diff] [review]
(Jv1b) </security/*>
[+/- Checked in: see Comment 76]

All the unused variable warnings in this
patch, except the last one (pkcs11u.c),
have been fixed on the NSS trunk.

I opened bug 229289 for the last warning.

Comment 76

[Serge Gautherie (:sgautherie)]

Comment on attachment 137588 [details] [diff] [review]
(Jv1b) </security/*>
[+/- Checked in: see Comment 76]

Addition to comment 75:

Check in : { wchang0222%aol.com Dec 23 13:__ }

Comment 77

[Brian Ryner (not reading)]

Comment on attachment 137549 [details] [diff] [review]
(Lv1) </widget/src/mac/*> (cleanup only)
[Checked in: Comment 78]

r=me.  I've been meaning to remove all the non-TARGET_CARBON code at some point
too.

Comment 78

[Serge Gautherie (:sgautherie)]

Comment on attachment 137549 [details] [diff] [review]
(Lv1) </widget/src/mac/*> (cleanup only)
[Checked in: Comment 78]


Check in: { 01/06/2004 15:24	neil%parkwaycc.co.uk	1.126 }

Comment 79

[(not reading, please use [e-mail] instead)]

Comment on attachment 137544 [details] [diff] [review]
(Gv1b) </mailnews/*>
[Checked in: Comment 80]

sr=sspitzer

Comment 80

[Serge Gautherie (:sgautherie)]

Comment on attachment 137544 [details] [diff] [review]
(Gv1b) </mailnews/*>
[Checked in: Comment 80]


Check in: { 01/09/2004 16:32	neil%parkwaycc.co.uk }

Comment 81

[Serge Gautherie (:sgautherie)]

Comment on attachment 137533 [details] [diff] [review]
(Av1c) </xpcom/*>
[Checked in: Comment 83]


No review from <[e-mail]> since '2003-12-16' :-(

Comment 82

[David Bradley]

Comment on attachment 137533 [details] [diff] [review]
(Av1c) </xpcom/*>
[Checked in: Comment 83]

r=dbradley

Comment 83

[Serge Gautherie (:sgautherie)]

Comment on attachment 137533 [details] [diff] [review]
(Av1c) </xpcom/*>
[Checked in: Comment 83]


Check in: { 2004-04-21 04:16	neil%parkwaycc.co.uk }

Comment 84

[Serge Gautherie (:sgautherie)]

Attachment: (Ov1) </mailnews/*> additional [Checked in: Comment 97]

Fixes for <http://tinderbox.mozilla.org/SeaMonkey/warn1082549640.1979.html>.

Comment 85

[Serge Gautherie (:sgautherie)]

Comment on attachment 146705 [details] [diff] [review]
(Ov1) </mailnews/*> additional
[Checked in: Comment 97]


I have no compiler: Could you (super-)review/compile/test/check in this patch ?
Thanks.

Comment 86

[Serge Gautherie (:sgautherie)]

Attachment: (Pv1) </profile/*> [Checked in: Comment 100]

Fixes for <http://tinderbox.mozilla.org/SeaMonkey/warn1082549640.1979.html>.

Comment 87

[Serge Gautherie (:sgautherie)]

Comment on attachment 146706 [details] [diff] [review]
(Pv1) </profile/*>
[Checked in: Comment 100]


I have no compiler: Could you (super-)review/compile/test/check in this patch ?
Thanks.

Comment 88

[Serge Gautherie (:sgautherie)]

Attachment: (Qv1) </ipc/*> [Checked in: Comment 96]

Fixes for <http://tinderbox.mozilla.org/SeaMonkey/warn1082549640.1979.html>.

Comment 89

[Serge Gautherie (:sgautherie)]

Comment on attachment 146707 [details] [diff] [review]
(Qv1) </ipc/*>
[Checked in: Comment 96]


I have no compiler: Could you (super-)review/compile/test/check in this patch ?
Thanks.

Comment 90

[Serge Gautherie (:sgautherie)]

Attachment: (Rv1) </security/*> additional [Checked in: Comment 92]

Fixes for <http://tinderbox.mozilla.org/SeaMonkey/warn1082549640.1979.html>.

Comment 91

[Serge Gautherie (:sgautherie)]

Comment on attachment 146708 [details] [diff] [review]
(Rv1) </security/*> additional
[Checked in: Comment 92]


I have no compiler: Could you review/compile/test/check in this patch ? Thanks.

Comment 92

[Wan-Teh Chang]

Comment on attachment 146708 [details] [diff] [review]
(Rv1) </security/*> additional
[Checked in: Comment 92]

r=wtc.	I've checked in this patch on the NSS tip (NSS 3.10).

Comment 93

[Daniel (Leaf) Nunes]

Comment on attachment 146707 [details] [diff] [review]
(Qv1) </ipc/*>
[Checked in: Comment 96]

it does, indeed, remove an unused variable warning and	compilation succeeds
normally. i'm not sure how to functionally test ipc, though.

Comment 94

[Daniel (Leaf) Nunes]

Comment on attachment 146707 [details] [diff] [review]
(Qv1) </ipc/*>
[Checked in: Comment 96]

punting super-revew to scc; this looks fine to me, scott, since, well, the
variable is unused and the function is void, to boot.

Comment 95

[Scott Collins]

Comment on attachment 146707 [details] [diff] [review]
(Qv1) </ipc/*>
[Checked in: Comment 96]

works for me; sr=scc

Comment 96

[Daniel (Leaf) Nunes]

Comment on attachment 146707 [details] [diff] [review]
(Qv1) </ipc/*>
[Checked in: Comment 96]

marking as obsolete, as this patch has been committed.

Comment 97

[Serge Gautherie (:sgautherie)]

Comment on attachment 146705 [details] [diff] [review]
(Ov1) </mailnews/*> additional
[Checked in: Comment 97]


Check in: { 2004-04-26 16:28	neil%parkwaycc.co.uk }

Comment 98

[Serge Gautherie (:sgautherie)]

Comment on attachment 146706 [details] [diff] [review]
(Pv1) </profile/*>
[Checked in: Comment 100]

No (super-)review from <[e-mail]> since '2004-04-21' :-(

***

I have no compiler: Could you (super-)review/compile/test/check in this patch ?
Thanks.

Comment 99

[rbs]

Comment on attachment 146706 [details] [diff] [review]
(Pv1) </profile/*>
[Checked in: Comment 100]

s=rbs, I had missed this from my review queue.

Comment 100

[Serge Gautherie (:sgautherie)]

Comment on attachment 146706 [details] [diff] [review]
(Pv1) </profile/*>
[Checked in: Comment 100]


Check in: { 2004-06-22 01:34	neil%parkwaycc.co.uk	mozilla/ profile/
pref-migrator/ src/ nsPrefMigration.cpp       1.195 }

Comment 101

[Serge Gautherie (:sgautherie)]

Attachment: (Sv1) </mailnews/*> 3rd

Fix for
{{
Linux brad Clobber (info) on 10/28 06:37

bienvenu

127.	mailnews/db/msgdb/src/nsMsgThread.cpp:410 (See build log excerpt)
	Unused variable `nsIMsgDBHdr*curMsgHdr'

408 {
409   nsMsgKey oldThreadParent, curHdrKey;
410   nsIMsgDBHdr *curMsgHdr = curHdr;
411   nsMsgHdr* oldTopLevelMsgHdr = NS_STATIC_CAST(nsMsgHdr*, oldTopLevelHdr); 
    // closed system, cast ok
412   curHdr->GetThreadParent(&oldThreadParent);
}}

Comment 102

[Serge Gautherie (:sgautherie)]

Attachment: (Sv1a) </mailnews/*> 3rd

Sv1, plus fix for the other "same" warnings in </mailnews/*>.

Comment 103

[Serge Gautherie (:sgautherie)]

Comment on attachment 163726 [details] [diff] [review]
(Sv1a) </mailnews/*> 3rd

I have no compiler: Could you (super-)review/compile/test/check in this patch ?
Thanks.

Comment 104

[Serge Gautherie (:sgautherie)]

Comment on attachment 163726 [details] [diff] [review]
(Sv1a) </mailnews/*> 3rd

No super-review from <[e-mail]> since "2004-10-28" :-(

I have no compiler: Could you (super-)review/compile/test/check in this patch ?
Thanks.

Comment 105

[[e-mail]]

Comment on attachment 163726 [details] [diff] [review]
(Sv1a) </mailnews/*> 3rd

Two of the hunks in this patch are no longer necessary and no longer apply
because the code in question was deleted. However, new code with new warnings
seems to have been added since ;-)

Comment 106

[Serge Gautherie (:sgautherie)]

Attachment: (Sv2_bB) </mailnews/*> 3rd

Sv1a, with comment 105 suggestion(s),
and "blank line" modifications.

Comment 107

[[e-mail]]

Comment on attachment 173324 [details] [diff] [review]
(Sv2_bB) </mailnews/*> 3rd

>Index: mozilla/mailnews/base/src/nsMsgGroupThread.cpp
>@@ -235,9 +229,8 @@ nsresult nsMsgGroupThread::ReparentNonRe
I don't think that the remaining changes in this file are useful, unless you
can point me to build warnings that they will fix.

>Index: mozilla/mailnews/db/msgdb/src/nsMsgThread.cpp
>@@ -407,7 +404,6 @@ nsresult nsMsgThread::ReparentNonReferen
>-      nsIMsgDBHdr *curMsgHdr = curHdr;
Nor the changes in this file, apart from this one looks ok.

The other changes look ok, but please double-check for other warnings in the
same files that you can fix at the same time.

Comment 108

[Serge Gautherie (:sgautherie)]

Attachment: (Sv3) </mailnews/*> 3rd

Sv2_bB, with comment 107 suggestion(s).

(Unrelated) I'm wondering about:
Index: mozilla/mailnews/import/comm4x/src/nsComm4xProfile.cpp
nsComm4xProfile::GetMailDir(const PRUnichar *aProfile, PRUnichar **_retval)
#if defined(XP_WIN) || defined(XP_OS2) || defined(XP_MACOSX)

#if defined(XP_MAC) || defined(XP_MACOSX)
// |XP_MAC| could be removed here, or should be added in the previous #ifdef !?


#if defined(XP_WIN) || defined(XP_OS2) || defined(XP_MAC) || defined(XP_MACOSX)

// Same; moreover, it duplicates the first #ifdef and could/should be removed
!?

Comment 109

[[e-mail]]

Comment on attachment 173500 [details] [diff] [review]
(Sv3) </mailnews/*> 3rd

>-  PRInt32 oldRecent = GetServerStateParser().NumberOfRecentMessages();
>+  // PRInt32 oldRecent =
>+    GetServerStateParser().NumberOfRecentMessages();
This can be commented out completely, see the comment further on in the file.
(Maybe both this and that comment should be removed compeltely, but I wouldn't
know about that) r=me with this nit fixed.

I think there's another bug filed on XP_MAC cleanup.

Comment 110

[Serge Gautherie (:sgautherie)]

Attachment: (Sv3a) </mailnews/*> 3rd [Checked in: Comment 114]

Sv3, with comment 109 suggestion(s).

Keeping
{{
(Sv3) </mailnews/*> 3rd 	 patch		2005-02-05 19:05 PST	5.68 KB
	neil.parkwaycc.co.uk: review+
}}

Comment 111

[Serge Gautherie (:sgautherie)]

(In reply to comment #109)
> I think there's another bug filed on XP_MAC cleanup.

Right: bug 196105.

Comment 112

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 173534 [details] [diff] [review]
(Sv3a) </mailnews/*> 3rd
[Checked in: Comment 114]

sr=dmose

Comment 113

[Asa Dotzler [:asa]]

Comment on attachment 173534 [details] [diff] [review]
(Sv3a) </mailnews/*> 3rd
[Checked in: Comment 114]

a=asa for 1.8b.

Comment 114

[Serge Gautherie (:sgautherie)]

Comment on attachment 173534 [details] [diff] [review]
(Sv3a) </mailnews/*> 3rd
[Checked in: Comment 114]


Check in: { 2005-02-16 03:50	neil%parkwaycc.co.uk }

Comment 115

[Jungshik Shin]

Attachment: (Tv1) transformiix/xpath

Just thought I'd help a bit.

Comment 116

[Serge Gautherie (:sgautherie)]

Comment on attachment 174788 [details] [diff] [review]
(Tv1) transformiix/xpath

Thanks !

I wonder if fixing
{{
10.	extensions/transformiix/source/xpath/XFormsFunctionCall.cpp:81 (See
build log excerpt)
	Unused variable `nsresult rv'

79 {
80   *aResult = nsnull;
81   nsresult rv = NS_OK;
82   txListIterator iter(&params);
}}
by simply removing line 81 would not be best,
since that |rv| not used at the end of the function.

Comment 117

[jon rekai]

*** Bug 282937 has been marked as a duplicate of this bug. ***

Comment 118

[Peter Van der Beken [:peterv]]

Comment on attachment 174788 [details] [diff] [review]
(Tv1) transformiix/xpath

Code was rewritten as part of the fix for bug 278981.

Comment 120

[Robert Kaiser]

compiler warnings are build config, let's put this there.

Comment 121

[Chris Peterson [:cpeterson]]

All -Wunused-variable warnings have been fixed. \o/