Closed Bug 1813045 Opened 2 years ago Closed 10 months ago

Can we tidy up extra_keys_with_types in rust/c++ codegen after the removal of old-style event extras?

Categories

(Toolkit :: Telemetry, task, P3)

Product:
Toolkit
Component:
Telemetry
Type:
task

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: chutten, Unassigned)

References

Details

In bug 1812615 we removed any codegen errors related to the previously-deprecated-now-removed events API. We might be able to tidy Rust and C++ codegen up even further as a result. At the very least, the comments in there can be rewritten.

This bug is about looking at extra_keys_with_types in rust.jinja2 and cpp.jinja2 and its invocations, and seeing if we can simplify/modernize it now that there's only one way event extras are parsed.

Assignee: nobody → pmcmanis

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: pmcmanis → nobody

I've now taken a look and I'm not sure what idea I had a year ago, but either we've already done the necessary changes in the intervening time or there was actually nothing we could do to simplify things in the first place. Looks pretty single-purpose these days.

Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → WORKSFORME
Summary: Can we tidy up extra_keys_with_types in rust/c++ codegen after the removal of old-style even extras? → Can we tidy up extra_keys_with_types in rust/c++ codegen after the removal of old-style event extras?
You need to log in before you can comment on or make changes to this bug.