1813302 - [Omnibox API] Deletable suggestion result menu is broken

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Gregory Pappas [:gregp]]

Attachment: broken_menu.png

Steps to reproduce:

1. Navigate to about:config
2. Set browser.urlbar.resultMenu to true
3. Navigate to https://github.com/gregorypappas/onDeleteSuggestion
4. Download and unzip the extension
5. Navigate to about:debugging -> This Firefox -> Temporary Extensions
6. Select 'Load Extension' and install the unzipped extension from step 4
7. Type omni 123 in the address bar
8. Click the result menu button on one of the rows provided by the extension

Actual results:
The menu is empty

Expected results:
The menu is not empty

Comment 1

[Gregory Pappas [:gregp]]

Attachment: Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r?dao,adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bd6e56348ff
Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw

Comment 3

[Cristina Horotan [:chorotan]]

Backed out changeset 0bd6e56348ff (bug 1813302) for causing xpc shell failures at test_providerOmnibox.js.

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0bd6e56348ffe735e8bc2220b822d5be4bf256fb&selectedTaskRun=VJVUDW7tTBuDJmAQwwdO4g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=403970789&repo=autoland&lineNumber=3687

Backout: https://hg.mozilla.org/integration/autoland/rev/334f960aac72ffa07f926d771b413697443b946b

Comment 4

[Gregory Pappas [:gregp]]

Thanks, working on it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/406eefb89345
Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/406eefb89345

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce the issue with the affected build from 2023-01-28 (20230128211106) using macOS 13.

Confirming this issue as verified fixed with 112.0a1(20230223094032) and 111.0b4(20230221190142) using Windows 11, macOS 13 and Ubuntu22 using the steps from the Description.