1813309 - Investigate if avoiding ensureLinear call under CopyStringChars would improve performance

Status: NEW

(Core :: JavaScript Engine, task, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

This is from VanillaJS-TodoMVC
https://share.firefox.dev/3Jq2HrZ
Gecko side passes large enough buffer https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/dom/base/nsJSUtils.h#118,122 so one should be able to just copy string data there without flattening the rope.

Comment 1

[Masoudahg]

Like 👍

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This showed up again when profiling ES5 test of sp3.
https://share.firefox.dev/3Q85w4y

Comment 3

[Jan de Mooij [:jandem]]

Starting Firefox and running the full Sp3 with the default harness, I see ~49500 calls to JS::detail::StringToLinearStringSlow (the function we end up calling for these JSAPI functions). In most cases (about 70%), the left child is another rope.

We should also try to avoid calling malloc for rope flattening. I filed bug 1880044 for that.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://share.firefox.dev/43g5rA6 is from a full sp3 run.