Support allocating flattened rope characters in the nursery
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [sp3])
Attachments
(4 files)
On a full Speedometer 3 run we call malloc about 200,000 times for rope flattening. Most of these (> 93% according to some quick-and-dirty logging) could instead allocate the buffer in the nursery.
This should be doable now after bug 1853907. I have a WIP patch that passes most tests, but it needs bug 1879918 to be fixed first.
Updated•4 months ago
|
Updated•4 months ago
|
Assignee | ||
Updated•2 months ago
|
Assignee | ||
Comment 1•2 months ago
|
||
This was added when we calculated the size manually, but with mallocSizeOf
we don't need special handling for extensible strings.
Assignee | ||
Comment 2•2 months ago
|
||
Assignee | ||
Comment 3•2 months ago
|
||
Also fixes/deletes some outdated comments.
Assignee | ||
Comment 4•2 months ago
|
||
Now that strings can have nursery-allocated chars, we can also use this when
flattening nursery-allocated ropes.
Assignee | ||
Comment 6•2 months ago
|
||
Improves TodoMVC-JavaScript-ES5/Adding100Items/Sync
by about 3.6%. Looking at the latest profile from Markus for this test, I do see some rope flattening time (under DOMParser.parseFromString
and Template.prototype.show
).
Comment 7•1 month ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jandem, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 8•1 month ago
|
||
Waiting for some other bugs to land first.
Description
•