1813481 - Allow 'none' keyword as color component

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tiaan Louw]

The keyword none is allowed to be passed as a component to any color format and the value of those components then defaults to 0.

https://drafts.csswg.org/css-color-4/#missing

Comment 1

[Tiaan Louw]

Attachment: Bug 1813481 - Use abstract color parser r=emilio,#layout-reviewers

In stead of having the css parser construct a color in it's own format
and then converting it to what Gecko needs to perform operations, we now
construct a Gecko friendly color type directly.

Comment 2

[Tiaan Louw]

Attachment: Bug 1813481 - Allow 'none' keyword in color components r=emilio,#layout-reviewers

Make use of the new changes in the cssparser that allows 'none' keywords
in color components where allowed. We store the none values as 0.0 (as
per the spec) and mark the components with the flags. This way we don't
have to check anything on the components before doing calculations.

Depends on D170187

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4764413c8662
Use abstract color parser r=emilio,supply-chain-reviewers

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4764413c8662

Comment 5

[Tiaan Louw]

This had multiple patches on the same bug number. Reopening for now

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e23971f01b
Allow 'none' keyword in color components r=emilio,supply-chain-reviewers

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39006 for changes under testing/web-platform/tests

Comment 8

[Cristina Horotan [:chorotan]]

Backed out changeset 00e23971f01b (bug 1813481) for causing multiple failures

Backout: https://hg.mozilla.org/integration/autoland/rev/589f49328267d8b35e0fc0e5761e04817d25a913

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=00e23971f01b12c264cfdb9b515b71af24d7732b

Failure logs:
xpcshell failures: https://treeherder.mozilla.org/logviewer?job_id=408976761&repo=autoland&lineNumber=3566
devtools failures: https://treeherder.mozilla.org/logviewer?job_id=408976549&repo=autoland&lineNumber=6957
mochitest failures: https://treeherder.mozilla.org/logviewer?job_id=408977357&repo=autoland&lineNumber=3923
Wc failure: https://treeherder.mozilla.org/logviewer?job_id=408977858&repo=autoland&lineNumber=4926
crashtest failure: https://treeherder.mozilla.org/logviewer?job_id=408979632&repo=autoland&lineNumber=14355
wpt failure: https://treeherder.mozilla.org/logviewer?job_id=408980718&repo=autoland&lineNumber=9942

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/deabee2364d4
Allow 'none' keyword in color components r=emilio,supply-chain-reviewers,devtools-reviewers

Comment 11

[Tiaan Louw]

Fixed a failure with missing devtool db changes. Landed again.

Comment 12

[Atila Butkovits]

Backed out for causing assertion failures at gfxUtils.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/beeec5bc3085235cb71573be725f487de029d545

Push where failures started failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=SJl6-I0ETxygbrYFpnvvWQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=35b95f712005a488ab2d7f6152eae75496509217

Failure log: https://treeherder.mozilla.org/logviewer?job_id=409030439&repo=autoland&lineNumber=16155

Comment 13

[Tiaan Louw]

Failure because of assertion that only hits in debug mode. Will land again.

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/160ac6b5f726
Allow 'none' keyword in color components r=emilio,supply-chain-reviewers,devtools-reviewers

Comment 16

[Marian-Vasile Laza]

Backed out changeset 160ac6b5f726 (Bug 1813481) for assertion failure on nsCSSRenderingGradients.cpp.
Backout link
Push with failures <--> Wc
Failure Log

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/188dde914364
Allow 'none' keyword in color components r=emilio,supply-chain-reviewers,devtools-reviewers

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/188dde914364

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot