Closed Bug 1823031 Opened 2 years ago Closed 2 years ago

Perma devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Completed value is correct - Got "style=\"display: inherit; color :cadetblue " when Gecko 113 merges to Beta on 2023-04-10

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox-esr102 unaffected, firefox111 unaffected, firefox112 unaffected, firefox113+ verified)

Status:
VERIFIED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox111 --- unaffected
firefox112 --- unaffected
firefox113 + verified

People

(Reporter: chorotan, Assigned: tlouw)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1823031 - Fix devtools test with color-mix disabled. r=emilio
48 bytes, text/x-phabricator-request
Details | Review

[Tracking Requested - why for this release]:

task 2023-03-17T10:58:43.311Z] 10:58:43     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Popup is open - 
[task 2023-03-17T10:58:43.312Z] 10:58:43     INFO - Entering test data 31: c, expecting: [style="display:  inherit; color :color ]
[task 2023-03-17T10:58:43.442Z] 10:58:43     INFO - Test data 31 entered. Checking state.
[task 2023-03-17T10:58:43.447Z] 10:58:43     INFO - TEST-INFO | started process screentopng
[task 2023-03-17T10:58:43.770Z] 10:58:43     INFO - TEST-INFO | screentopng: exit 0
[task 2023-03-17T10:58:43.773Z] 10:58:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Completed value is correct - Got "style=\"display:  inherit; color :cadetblue ", expected "style=\"display:  inherit; color :color "
[task 2023-03-17T10:58:43.773Z] 10:58:43     INFO - Stack trace:
[task 2023-03-17T10:58:43.773Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:test_is:1512
[task 2023-03-17T10:58:43.773Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/helper_style_attr_test_runner.js:checkData:127
[task 2023-03-17T10:58:43.773Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/helper_style_attr_test_runner.js:runStyleAttributeAutocompleteTests:59
[task 2023-03-17T10:58:43.774Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js:null:93
[task 2023-03-17T10:58:43.774Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:handleTask:1039
[task 2023-03-17T10:58:43.774Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1111
[task 2023-03-17T10:58:43.774Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1253
[task 2023-03-17T10:58:43.775Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1028
[task 2023-03-17T10:58:43.775Z] 10:58:43     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1053
[task 2023-03-17T10:58:43.775Z] 10:58:43     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Selection start position is correct - 
[task 2023-03-17T10:58:43.775Z] 10:58:43     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-03-17T10:58:43.776Z] 10:58:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Selection end position is correct - Got 42, expected 38
[task 2023-03-17T10:58:43.776Z] 10:58:43     INFO - Stack trace:
[task 2023-03-17T10:58:43.776Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:test_is:1512
[task 2023-03-17T10:58:43.776Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/helper_style_attr_test_runner.js:checkData:133
[task 2023-03-17T10:58:43.777Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/helper_style_attr_test_runner.js:runStyleAttributeAutocompleteTests:59
[task 2023-03-17T10:58:43.777Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js:null:93
[task 2023-03-17T10:58:43.777Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:handleTask:1039
[task 2023-03-17T10:58:43.777Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1111
[task 2023-03-17T10:58:43.778Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1253
[task 2023-03-17T10:58:43.778Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1028
[task 2023-03-17T10:58:43.778Z] 10:58:43     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1053
[task 2023-03-17T10:58:43.779Z] 10:58:43     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Popup is open - 
[task 2023-03-17T10:58:43.780Z] 10:58:43     INFO - Entering test data 32: VK_DOWN, expecting: [style="display:  inherit; color :color-mix ]
[task 2023-03-17T10:58:43.781Z] 10:58:43     INFO - Adding event listener for down|left|right|back_space|return keys
[task 2023-03-17T10:58:43.781Z] 10:58:43     INFO - Test data 32 entered. Checking state.
[task 2023-03-17T10:58:43.781Z] 10:58:43     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-03-17T10:58:43.782Z] 10:58:43     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Completed value is correct - Got "style=\"display:  inherit; color :chartreuse ", expected "style=\"display:  inherit; color :color-mix "
[task 2023-03-17T10:58:43.783Z] 10:58:43     INFO - Stack trace:
[task 2023-03-17T10:58:43.783Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:test_is:1512
[task 2023-03-17T10:58:43.783Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/helper_style_attr_test_runner.js:checkData:127
[task 2023-03-17T10:58:43.783Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/helper_style_attr_test_runner.js:runStyleAttributeAutocompleteTests:59
[task 2023-03-17T10:58:43.784Z] 10:58:43     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js:null:93
[task 2023-03-17T10:58:43.784Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:handleTask:1039
[task 2023-03-17T10:58:43.785Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1111
[task 2023-03-17T10:58:43.785Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1253
[task 2023-03-17T10:58:43.785Z] 10:58:43     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1028
[task 2023-03-17T10:58:43.785Z] 10:58:43     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1053
[task 2023-03-17T10:58:43.785Z] 10:58:43     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js | Selection start position is correct - 
[task 2023-03-17T10:58:43.786Z] 10:58:43     INFO - Not taking screenshot here: see the one that was previously logged
Flags: needinfo?(tiaanl)

After patch from bug 1813497 was merged in Central, the actual failure became: Completed value is correct - Got "style=\"display: inherit; color :coral ", expected "style=\"display: inherit; color :color-mix ", as it can be seen in today's central as beta simulation.

Tiaan, could you please take another look at this?

Thank you!

Found the drop here. NI sent to personal account and not Mozilla account. Tiaan will pick this up as I reached him on Slack. He's actually on the way to 2 weeks of PTO but thinks this should be a quick fix.

Assignee: nobody → tlouw

This devtools test was assuming the color-mix flag is enabled, which it
is on nightly, but not on beta/release, so checking the flag during the
test.

Pushed by tlouw@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab799f42afa9 Fix devtools test with color-mix disabled. r=devtools-reviewers,nchevobbe

https://hg.mozilla.org/mozilla-central/rev/ab799f42afa9

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox113: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Fix verified in today's beta-sim.

Status: RESOLVED → VERIFIED
status-firefox113: fixed → verified
Flags: needinfo?(tiaanl)
Regressions: 1825560
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: