1813554 - [KDE] Can't resize the Firefox window after CSD enabled

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Gian-Carlo Pascutto [:gcp]]

After bug 1812289 it's no longer possible to resize the Firefox window with the mouse. Hovering over the corners doesn't display the expected affordances for this.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

After playing around more, first dragging the window more to the center so the corners or sides are fully exposed, and then hovering, does show the resize affordance. But this works badly with edge snapping.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1812289

:emilio, since you are the author of the regressor, bug 1812289, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

So just to clarify, this is only an issue when the window is snapped to the top of the screen, right? You expect a resize handle there but there isn't. Other apps (including Chromium) seem to deal with this while painting to the titlebar, but they don't seem to deal with it on the other edges on the screen. Does that match your observations?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

gedit seems to show the same issue.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

So just to clarify, this is only an issue when the window is snapped to the top of the screen, right? You expect a resize handle there but there isn't.

Yes, top and top right.

they don't seem to deal with it on the other edges on the screen. Does that match your observations?

Yes. Konsole, for example behaves the same, so I guess that's "working as intended".

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1813554 - Clean-up CheckResizerEdge. r=stransky

No behavior change.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Alright, that shouldn't be controversial I think.

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1813554 - Add one pixel of artificial resize margin to the top of the window when drawing to the titlebar. r=stransky

This allows resizing tiled windows easily on KDE which is not possible
otherwise.

Depends on D168282

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1813554 - Make resize cursors match GTK ones. r=stransky

Depends on D168283

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e061c8d818cf
Clean-up CheckResizerEdge. r=stransky

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57238062192d
Make resize cursors match GTK ones. r=stransky

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e061c8d818cf
https://hg.mozilla.org/mozilla-central/rev/57238062192d

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08b6af27b2ea
Add one pixel of artificial resize margin to the top of the window when drawing to the titlebar. r=stransky

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/08b6af27b2ea