1822764 - Mouse not interacting with tab bar of non-maximized window at the top edge of the screen

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Julien Falque]

Attachment: Screencast of the issue

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

I reproduce this on Gnome desktop (Wayland), at least on an up-to-date Arch Linux and Ubuntu 22.10.

• Move a non-maximized Firefox window to the top edge of the screen
• Try to interact with the tab bar (e.g. closing a tab with middle click, or left click on the new tab button) while having the mouse pointer at the very top of the screen

Actual results:

The mouse actually interacts with the edge of the window, i.e. it starts to resize it.

If you right click there, the resizing will continue even if you release the mouse button. You need to left click to stop the resizing.

Expected results:

The mouse should have interacted with the tab bar (pre-v111 behavior).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Kestrel]

Not Wayland-specific and seems to be intentional, however the native titlebar and other native apps on Ubuntu 22.10 do not have this behavior.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9c484601dceb9159cb363f2bc0d52e313bc33f1e&tochange=08b6af27b2ea004809b29b47c2df0ce7eb6f6397

Regressed by Bug 1813554.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1813554, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1822764 - Only do the extra resizer pixel on KDE. r=stransky

It doesn't match the native GNOME behavior, so keep it in that DE only.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30618bdaad42
Only do the extra resizer pixel on KDE. r=stransky

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/30618bdaad42

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9325136 [details]
Bug 1822764 - Only do the extra resizer pixel on KDE. r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Reverts behavior to pre-111 behavior.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9325136 [details]
Bug 1822764 - Only do the extra resizer pixel on KDE. r=stransky

Approved for 112.0b9

Comment 10

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a18dbf2a4053

Comment 11

[Ina Popescu, Desktop QA]

Attachment: resizing.webm

I wasn't able to reproduce this issue in the KDE environment using Nightly 113.0a1(15-03-2023) on Ubuntu 22.04 following the STR from Comment 0.
@Julien Falque, could you please let us know if the issue can still be reproduced in the latest Nightly 113.0a1 and Firefox 112.0 versions?

While checking this issue in the Gnome environment, I've reproduced it using Nightly 113.0a1(15-03-2023) on Ubuntu 22.04.
@Emilio, I've noticed that in the latest Nightly 113.0a1 it's no longer possible to resize the browser window by dragging. Please see the attachment. Should I file a separate bug for this?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Yeah, kde shouldn't have changed behavior with this patch, and the gnome thing is intentional as per comment 0

Comment 13

[Julien Falque]

I confirm I can't reproduce the issue on Arch Linux with Firefox 112.0rc2-1.

Comment 14

[Ina Popescu, Desktop QA]

Thank you for confirming.
Marking this as VERIFIED FIXED.