1814275 - Port bug 1795255: Stop importing useless modules in browser tests

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Geoff Lankow (:darktrojan)]

Lots of things to fix but it looks like --fix will do the job for us.

Comment 1

[:Gijs (he/him)]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

Lots of things to fix but it looks like --fix will do the job for us.

Broadly yes. Just keep an eye out for any tests that mistakenly get the "browser-test" env file applied to them when they're really xpcshell tests or similar (because they're in the same directory as browser tests) - or for cases where existing globals (either DOM ones or ones defined by window-global scripts) have name conflicts with imported modules.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1814275 - Port bug 1795255: Stop importing useless modules in browser tests. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2775e37bbbc8
Port bug 1795255: Stop importing useless modules in browser tests. r=freaktechnik

Comment 4

[Intermittent Failures Robot]

1 failures in 3606 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• lint: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1814275&startday=2023-01-30&endday=2023-02-05&tree=all