Closed Bug 1814422 Opened 1 year ago Closed 1 year ago

Replace html:a link in searchResults.inc.xhtml with moz-support-link

Categories

(Toolkit :: UI Widgets, task, P3)

Product:
Toolkit
Component:
UI Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
113 Branch
Tracking Flags:
Tracking Status
firefox113 --- fixed

People

(Reporter: tgiles, Assigned: helloshahx95, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [recomp] [lang=html] [lang=js])

Attachments

(1 file)

Bug 1814422 - Replace html:a link in searchResults.inc.xhtml with moz-support-link. r?tgiles
48 bytes, text/x-phabricator-request
Details | Review

Another instance of a SUMO link, so we should replace it with a moz-support-link that handles this for us. Not sure where we need to import the moz-support-link module though.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help.
    This will tell others that you're working on the next steps.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
  3. Start working on this bug.
    • You'll need to navigate to about:preferences and use the search bar for this "Nightly Support" link to appear. For example, I typed in "ajklf" and then the "Nightly Support" link appears since there are no search results for this string.
    • You'll need to replace this <html:a> element with <html:a is="moz-support-link" ... > and ensure the text remains the same. I.e. make sure "Nightly Support" appears instead of the generic "Learn more".
  • The <moz-support-link> element should already be available to use in this context, please reach out if replacing the element does nothing. Also please refer to comment #0 to determine where you need to work.
  • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
  1. Build your change with mach build and verify your changes. Also check your changes for adherence to our style guidelines by using mach lint.
  2. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  3. After a series of reviews and changes to your patch, I'll push it to autoland.
Mentor: tgiles
Keywords: good-first-bug
Whiteboard: [fidefe-reusable-components] → [fidefe-reusable-components] [lang=html] [lang=js]

Hi, I would like to help fix this bug "Replace html:a link in searchResults.inc.xhtml with moz-support-link"

Hi Tim, I am looking into this bug and interested in working on the next steps.

Can I work on this issue?

Flags: needinfo?(tgiles)

Hi Tim, I am interested in working on this bug!

Assignee: nobody → evaojeogwu
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)

hey :pratikaswani9333 are you still interested in this bug? I noticed you haven't been assigned to one yet, and I believe the current applicant is no longer participating in this round of Outreachy. Let me know!

Flags: needinfo?(pratikaswani9333)

(In reply to Hanna Jones [:hjones] from comment #6)

hey :pratikaswani9333 are you still interested in this bug? I noticed you haven't been assigned to one yet, and I believe the current applicant is no longer participating in this round of Outreachy. Let me know!

Hi Hanna! I am interested in working on this, I'm an outreach applicant

Flags: needinfo?(tgiles)

Hey Blessing Peters - thanks for your interest! I'm going to wait to see if :pratikaswani9333 as they are not currently assigned to any bugs. It looks like you have a bug you are assigned to - please focus on completing any in progress bugs before commenting on/trying to get assigned to others.

Flags: needinfo?(tgiles)

(In reply to Hanna Jones [:hjones] from comment #8)

Hey Blessing Peters - thanks for your interest! I'm going to wait to see if :pratikaswani9333 as they are not currently assigned to any bugs. It looks like you have a bug you are assigned to - please focus on completing any in progress bugs before commenting on/trying to get assigned to others.

Ohh okay. Got it.

(In reply to Hanna Jones [:hjones] from comment #8)

Hey Blessing Peters - thanks for your interest! I'm going to wait to see if :pratikaswani9333 as they are not currently assigned to any bugs. It looks like you have a bug you are assigned to - please focus on completing any in progress bugs before commenting on/trying to get assigned to others.

Hello Hanna! I've just completed the bug I was assigned to and I'm now looking for the next task. I'm still very interested in working on this bug if it's still available. Please Let me know.

Flags: needinfo?(tgiles)
Assignee: evaojeogwu → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(tgiles)

Hello! I noticed that the bug is currently unassigned and I was wondering if It could be assigned to me.

Flags: needinfo?(tgiles)

hello, do we need to first patch in order to be assigned this bug,

Clearing the needinfos. Assigning to briannapatricia since they have not yet had a chance to contribute to Firefox. Thank you for your interest Blessing, but I see that you've resolved a bug already. Feel free to search for other bugs to fix Blessing!

Assignee: nobody → briannapatricia7
Status: NEW → ASSIGNED
Flags: needinfo?(tgiles)
Flags: needinfo?(pratikaswani9333)

(In reply to Tim Giles [:tgiles] from comment #13)

Clearing the needinfos. Assigning to briannapatricia since they have not yet had a chance to contribute to Firefox. Thank you for your interest Blessing, but I see that you've resolved a bug already. Feel free to search for other bugs to fix Blessing!

sure thing!

thanks Tim,

hello @Tim, i am still finding challenges in submitting the patches. and viewing my changes too.

and another issue, what changes are we making on comment #0 second link

Brianna, what issues are you running into? Have you followed along with the getting set up to work on the Firefox codebase guide?

After adding the moz-support-link call, you can remove the code referenced in https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/preferences/findInPage.js#61-65 since the moz-support-link custom element handles that href assignment for us.

Hi. May I take over the bug if Brianna is no longer actively addressing it? There have been no recent updates on its status.

Flags: needinfo?(tgiles)

Brianna, are you still running into issues with this bug? Please let me know how I can help.

Shah, I will give Brianna a day or so to respond. If Brianna no longer wants to work on this bug, I will open it up for anyone else to work on it (the assignee will go to nobody).

Keeping my NI open as a reminder.

Flags: needinfo?(tgiles) → needinfo?(briannapatricia7)

weird, meant to keep my NI open, this should fix that.

Flags: needinfo?(tgiles)

(In reply to Tim Giles [:tgiles] from comment #19)

Shah, I will give Brianna a day or so to respond. If Brianna no longer wants to work on this bug, I will open it up for anyone else to work on it (the assignee will go to nobody).
Sounds good.

Shah, switching the assignee over to you. Feel free to needinfo me if you need help, thanks.

Assignee: briannapatricia7 → helloshahx95
Flags: needinfo?(tgiles)
Flags: needinfo?(briannapatricia7)

Thanks, Tim. I have submitted a patch for the bug.

Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83cf2db6778d
Replace html:a link in searchResults.inc.xhtml with moz-support-link. r=tgiles

https://hg.mozilla.org/mozilla-central/rev/83cf2db6778d

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox113: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
Whiteboard: [fidefe-reusable-components] [lang=html] [lang=js] → [recomp] [lang=html] [lang=js]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: