1814424 - Use moz-support-link for the "helpButton" link in preferences.xhtml

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

We should be able to use moz-support-link on this "helpButton" instead of just a plain HTML anchor.

• https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/preferences/preferences.xhtml#177
• https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/preferences/preferences.js#253-257

Comment 1

[Tim Giles [:tgiles]]

Hmm, I thought this was going to be a good candidate for a good-first-bug, but on second glance...that's not gonna be the case. The <moz-support-link> component does not handle this case. This particular instance, which you can find in the about:preferences sidebar labelled "Nightly Support" (if you are running Nightly), has an anchor with an <image> and a <label> inside of the anchor. If we simply try to replace this with a <moz-support-link> element, we will lose the image tag. Some further investigation will need to be done to determine why the support-link component is deleting any tags within it. Might be something to do with the Fluent translation, I'm not sure.

Comment 2

[Ganna]

Attachment: Bug 1814424 - Use moz-support-link for the helpButton link in preferences.xhtml r=tgiles

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c255581fd1f
Use moz-support-link for the helpButton link in preferences.xhtml r=tgiles,settings-reviewers,Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c255581fd1f

Comment 5

[Tim Giles [:tgiles]]

Comment on attachment 9337282 [details]
Bug 1814424 - Use moz-support-link for the helpButton link in preferences.xhtml r=tgiles

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for Bug 1840953 to graft cleanly so that the link within the "Personalized Your Nightly" section of about:addons will be localized correctly
• User impact if declined: Users may be confused by the recommended extensions link in about:addons since the sentence will be "Here's a selection Firefox Learn more for exceptional security, performance, and functionality".
• Fix Landed on Version: 116
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is limited to one UI element in about:preferences

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9337282 [details]
Bug 1814424 - Use moz-support-link for the helpButton link in preferences.xhtml r=tgiles

Approved for 115.1esr

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/a43b3b04882f