1814427 - Replace "linkMoreTroubleshooting" xul anchor with moz-support-link

Status: RESOLVED FIXED

(Toolkit :: XUL Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

Since the "linkMoreTroubleshooting" anchor is always present, we can simplify the JS for this element by using moz-support-link instead.

• https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/migration/content/aboutWelcomeBack.xhtml#38
• https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/sessionstore/content/aboutSessionRestore.js#35-39

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • You can load the page in question by navigating to about:welcomeback and using the devtools to inspect the page to find the link in question.
   • You may need to import the moz-support-link module in the head of aboutWelcomeBack.xhtml. You can see an example of this import in https://phabricator.services.mozilla.com/D166463
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/components/privatebrowsing/test/browser/browser_privatebrowsing_aboutSessionRestore.js --headless and mach test browser/components/sessionstore/test/browser_aboutSessionRestore.js --headless. You should also verify the link takes you to the troubleshooting page as it previously did. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 2

[anayocrescent2]

please can you assign this to me

Comment 3

[Lata]

(In reply to anayocrescent2 from comment #2)

please can you assign this to me

Are you working on it? If not can I be assigned?

Comment 4

[anayocrescent2]

yes, i have commited my patch

Comment 5

[anayocrescent2]

Attachment: Bug 1814427 - Replace linkMoreTroubleshooting xul anchor with moz-support-link r?tgiles

Comment 6

[anayocrescent2]

Attachment: Bug 1814427 - Replace linkMoreTroubleshooting xul anchor with moz-support-link r?tgiles

Depends on D172221

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f03dcb44cd1
Replace linkMoreTroubleshooting xul anchor with moz-support-link r=tgiles

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4f03dcb44cd1