Closed Bug 1814459 Opened 3 years ago Closed 1 month ago

Implement RTCError for SDP parse errors

Categories

(Core :: WebRTC: Signaling, task, P3)

task

Tracking

()

RESOLVED FIXED
150 Branch
Tracking Status
firefox150 --- fixed

People

(Reporter: bwc, Assigned: iamanshulmalik)

References

(Blocks 5 open bugs)

Details

(Keywords: dev-doc-needed)

Attachments

(2 files)

This covers the initial steps of adding RTCError and RTCErrorDetailTypes, refactoring JsepSession to be able to throw RTCError (as well as a plain DOMException), and filling out RTCError.sdpLineNumber.

Blocks: 1814460
Blocks: 1814461
Blocks: 1814464
Severity: -- → N/A
Type: defect → task
Priority: -- → P3

I'd like to give it a try.

Adds the RTCError (DOMException subclass) and RTCErrorEvent (Event subclass)
interfaces as a prerequisite for plumbing RTCError through SDP, DTLS, SCTP,
and hardware encoder failure paths.

RTCError.sdpLineNumber and JsepSession integration are follow-up in this bug.

Assignee: nobody → iamanshulmalik
Status: NEW → ASSIGNED
See Also: → 1806181
See Also: → 1617686
See Also: 1617686
Pushed by bcampen@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/33b22a373fdf https://hg.mozilla.org/integration/autoland/rev/fdce8626e275 Part 1. Add RTCError and RTCErrorEvent WebIDL interfaces and base C++ implementation. r=bwc,webidl,saschanaz,smaug https://github.com/mozilla-firefox/firefox/commit/423113553307 https://hg.mozilla.org/integration/autoland/rev/2c30cb9e11be Part 2. Wire RTCError into SDP parse error rejection path. r=bwc,webidl,smaug
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
QA Whiteboard: [qa-triage-done-c151/b150]

Was the omission of the dev-doc-needed keyword deliberate - i.e. is there a reason this should not be documented?

If it needs to be, please add that keyword because otherwise MDN doesn't get a trigger to do anything. Note that compatibility data got recorded already in https://github.com/mdn/browser-compat-data/pull/29352 - also I am assuming that this is shipped as well, since there is no obvious preference gating this.

Flags: needinfo?(iamanshulmalik)
Flags: needinfo?(iamanshulmalik)
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: