1814460 - Implement RTCError for DataChannel/sctp failures

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P3)

Comment 1

[Byron Campen [:bwc]]

Interop 2026 does not directly include RTCError, but it does include test-cases in RTCDataChannel-close.html that are failing for lack of this.

Nevermind, missed this because there is a single test case in RTCError.html that isn't in interop 2026.

Comment 2

[Byron Campen [:bwc]]

Note: RTCErrors of this kind can be thrown at RTCDataChannel, and those can be on workers, but the spec only exposes the interface on Window. That's probably a spec bug. I've filed https://github.com/w3c/webrtc-pc/issues/3092

Comment 3

[Byron Campen [:bwc]]

It looks like this will mainly clear up failures here:

https://wpt.fyi/results/webrtc/RTCDataChannel-close.html?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2026-webrtc

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1814460: Surface RTCError for SCTP failures. r?mjf

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/23a9de79fb37
https://hg.mozilla.org/integration/autoland/rev/ba21fba7a7fb
Surface RTCError for SCTP failures. r=mjf,webidl,saschanaz,dom-worker-reviewers,asuth

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/315326a1e8a3
https://hg.mozilla.org/integration/autoland/rev/d00038d023f3
Revert "Bug 1814460, Bug 2019353: Surface RTCError for SCTP failures. r=mjf,webidl,saschanaz,dom-worker-reviewers,asuth" for causing mass failures.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mass failures.

• Revert link
• Push with failures
• Failure Log - gtest
• Failure Log - mochitests-plain

Comment 8

[Byron Campen [:bwc]]

Ah, missed the serviceworker stuff.

Comment 9

[Byron Campen [:bwc]]

Actually, RTCError probably should be exposed on DedicatedWorker rather than Worker, for consistency with RTCDataChannel.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2354187b1212
https://hg.mozilla.org/integration/autoland/rev/a0105e99bc37
Surface RTCError for SCTP failures. r=mjf,webidl,saschanaz,dom-worker-reviewers,asuth

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3a0b1f214836
https://hg.mozilla.org/integration/autoland/rev/2f9576e63cd2
Revert "Bug 1814460, Bug 2019353: Surface RTCError for SCTP failures. r=mjf,webidl,saschanaz,dom-worker-reviewers,asuth" for causing gtest failures @SetLocalAnswerInHaveLocalOffer.

Comment 12

[agoloman]

Backed out for causing gtest failures @SetLocalAnswerInHaveLocalOffer.

• Backout link
• Push with failures
• Failure Log gtest
• Failure log mochitest

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7ef270ad6a90
https://hg.mozilla.org/integration/autoland/rev/8211d03631e3
Surface RTCError for SCTP failures. r=mjf,webidl,saschanaz,dom-worker-reviewers,asuth

Comment 14

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/8211d03631e3

Comment 16

[Hamish Willee]

FF155 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/45175