Open Bug 1814485 Opened 3 years ago Updated 1 year ago

Can we enable media.peerconnection.mute_on_bye_or_timeout now?

Categories

(Core :: WebRTC: Signaling, task)

Product:
Core
Component:
WebRTC: Signaling
Type:
task

Tracking

()

People

(Reporter: bwc, Assigned: bwc)

References

Details

This comment says that we are waiting on bug 1232234 to enable this, but it seems bug 1232234 was resolved a while back. Can we just enable this now?

https://searchfox.org/mozilla-central/rev/9dfda5ccb0fc42d7666a54b1caf1af6525e49694/dom/media/webrtc/jsapi/RTCRtpReceiver.cpp#123-126

Assignee: nobody → docfaraday

Looks like we might still be firing extra mute events (maybe due to gratuitous RTCP BYE). Maybe the cleanup over in bug 1813468 will help with this.

See Also: → 1813468

Checked again, we still need this. :(

IIRC a (libwebrtc) send stream sends RTCP BYE when being destroyed. So any code we have that may recreate a send stream to apply some settings that can't be applied on the fly will cause RTCP BYE and a mute event on the receive side.

You need to log in before you can comment on or make changes to this bug.