1813468 - Fix RemoteTrackSource reference traversal and unlinking

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

See bug 1807700 comment 1 about RemoteTrackSource.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - In WPT test that a peer connection receiving video cannot be garbage collected. r?jib!

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Move RemoteTrackSource definitions to cpp file. r?bwc!

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Implement reference traversal and unlinking for RemoteTrackSource. r?bwc!

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Consolidate PeerConnectionImpl's PrivacyRequested and PrivacyNeeded. r?bwc!

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Use an enum for principal privacy in PeerConnectionImpl and friends. r?bwc!

Comment 6

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Trigger setting the private PrincipalHandle in MediaPipeline through RTCRtpReceiver. r?bwc!

This removes one dependency in MediaPipeline on RemoteTrackSource.

Comment 7

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Make RemoteTrackSource an RTCRtpReceiver member and add it to CC traversal. r?bwc!

Comment 8

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Simplify remote SourceMediaTrack ownership model. r?bwc!

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Move unmute-after-enabling logic out of MediaPipeline into RTCRtpReceiver. r?bwc!

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Remove RemoteTrackSource from MediaPipeline. r?bwc!

Comment 11

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Fix some warnings around MediaPipeline. r?bwc!

Comment 12

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - In RemoteTrackSource add a ref to RTCRtpReceiver to prevent GC at the wrong time. r?bwc!

Comment 13

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Rename ConcreteConduitControl to not be specific for conduits. r?bwc!

This sets it up so MediaPipeline control interfaces can be added.

Comment 14

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Rework RTCRtpReceiver unmute logic through Watchables. r?bwc!

This patch makes RTCRtpReceiver in charge of mute and unmute decisions directly.
MediaPipeline still informs about unmuting after receiving the first RTP packet.

This also removes a dependency on RTCRtpReceiver::Stop that is out of sync
with mReceiving = false.

Comment 15

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Signal start and stop to MediaPipeline through state mirroring. r?bwc!

Comment 16

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Remove unused member function declarations in RTCRtpSender.h. r?bwc!

Comment 17

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - In RTCRtpSender stop RTCDTMFSender playout through a WatchManager. r?bwc!

This patch fixes an issue where playout of queued DTMF tones could get
interrupted for unrelated reasons. This happened if a task, in a transmitting
RTCRtpSender, called both Stop() and then again Start().

With a WatchManager we watch for changes to mTransmitting and setting it to
false and then true in a single task gets coalesced into a noop.

Comment 18

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1813468 - Don't block unmute when the jseptrack is inactive. r?bwc!

This matches that we do not mute when the jseptrack is inactive.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/109d1020117a
In WPT test that a peer connection receiving video cannot be garbage collected. r=jib
https://hg.mozilla.org/integration/autoland/rev/c28bf2b7d094
Move RemoteTrackSource definitions to cpp file. r=bwc
https://hg.mozilla.org/integration/autoland/rev/0f2aa0156add
Implement reference traversal and unlinking for RemoteTrackSource. r=bwc
https://hg.mozilla.org/integration/autoland/rev/4efc6b3c9527
Consolidate PeerConnectionImpl's PrivacyRequested and PrivacyNeeded. r=bwc
https://hg.mozilla.org/integration/autoland/rev/dea5d02d4dbb
Use an enum for principal privacy in PeerConnectionImpl and friends. r=bwc
https://hg.mozilla.org/integration/autoland/rev/a0d17c5a5b11
Trigger setting the private PrincipalHandle in MediaPipeline through RTCRtpReceiver. r=bwc
https://hg.mozilla.org/integration/autoland/rev/f2d5a8a91ed2
Make RemoteTrackSource an RTCRtpReceiver member and add it to CC traversal. r=bwc
https://hg.mozilla.org/integration/autoland/rev/61a7f60b178c
Simplify remote SourceMediaTrack ownership model. r=bwc
https://hg.mozilla.org/integration/autoland/rev/be83a372e63b
Move unmute-after-enabling logic out of MediaPipeline into RTCRtpReceiver. r=bwc
https://hg.mozilla.org/integration/autoland/rev/765bd8c21710
Remove RemoteTrackSource from MediaPipeline. r=bwc
https://hg.mozilla.org/integration/autoland/rev/5a551138a5d1
Fix some warnings around MediaPipeline. r=bwc
https://hg.mozilla.org/integration/autoland/rev/d1dbd2ad49ba
In RemoteTrackSource add a ref to RTCRtpReceiver to prevent GC at the wrong time. r=bwc
https://hg.mozilla.org/integration/autoland/rev/f3f3da28953c
Rename ConcreteConduitControl to not be specific for conduits. r=bwc
https://hg.mozilla.org/integration/autoland/rev/677062c9bf1a
Rework RTCRtpReceiver unmute logic through Watchables. r=bwc
https://hg.mozilla.org/integration/autoland/rev/1c1098e1e1fc
Signal start and stop to MediaPipeline through state mirroring. r=bwc
https://hg.mozilla.org/integration/autoland/rev/1d8a6c3290a6
Remove unused member function declarations in RTCRtpSender.h. r=bwc
https://hg.mozilla.org/integration/autoland/rev/3cf25f108bff
In RTCRtpSender stop RTCDTMFSender playout through a WatchManager. r=bwc
https://hg.mozilla.org/integration/autoland/rev/ebfb7a062761
Don't block unmute when the jseptrack is inactive. r=bwc

Comment 20

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38433 for changes under testing/web-platform/tests

Comment 21

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/109d1020117a
https://hg.mozilla.org/mozilla-central/rev/c28bf2b7d094
https://hg.mozilla.org/mozilla-central/rev/0f2aa0156add
https://hg.mozilla.org/mozilla-central/rev/4efc6b3c9527
https://hg.mozilla.org/mozilla-central/rev/dea5d02d4dbb
https://hg.mozilla.org/mozilla-central/rev/a0d17c5a5b11
https://hg.mozilla.org/mozilla-central/rev/f2d5a8a91ed2
https://hg.mozilla.org/mozilla-central/rev/61a7f60b178c
https://hg.mozilla.org/mozilla-central/rev/be83a372e63b
https://hg.mozilla.org/mozilla-central/rev/765bd8c21710
https://hg.mozilla.org/mozilla-central/rev/5a551138a5d1
https://hg.mozilla.org/mozilla-central/rev/d1dbd2ad49ba
https://hg.mozilla.org/mozilla-central/rev/f3f3da28953c
https://hg.mozilla.org/mozilla-central/rev/677062c9bf1a
https://hg.mozilla.org/mozilla-central/rev/1c1098e1e1fc
https://hg.mozilla.org/mozilla-central/rev/1d8a6c3290a6
https://hg.mozilla.org/mozilla-central/rev/3cf25f108bff
https://hg.mozilla.org/mozilla-central/rev/ebfb7a062761

Comment 22

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot