1814607 - Wait for "reloaded" event in debugger tests on navigation/reload

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

For now, the debugger test are using navigateTo test helper, but this isn't waiting for panel's reloaded event.
It means that if the debugger does anything during navigation, the tests won't be correctly waiting for the completion of this work.
This is a blocker for bug 1809168 as it starts doing late RDP request when the page is done loading. i.e. when DOCUMENT_EVENT dom-complete event is fired.

Unfortunately, doing this highlight issues with inline scripts.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1814607 - [devtools] Wait for debugger frontend async work on navigation in all tests.

We weren't waiting for "reloaded" event of the debugger and so potentialy resolving
before some async work completed during page navigation.

The main challenge here is that when the test pause the navigation,
navigate and reload test helpers will no longer resolve until the debugger resumes
execution.

I also had to tweak the DOCUMENT_EVENT support for WebExtension.
We still have to accept "frame switching" for WebExt (while keeping it off for the browser toolbox).
Otherwise the debugger doesn't update when reloading the addon or switching between addon documents.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aff754cf0b3f
[devtools] Wait for debugger frontend async work on navigation in all tests. r=devtools-reviewers,nchevobbe

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1814607, Bug 1814608, Bug 1809168) for causing devtools failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8f7f098d9af03eed0fc6fc4c1e71734e797aa215&searchStr=os%2Cx%2C10.15%2Cwebrender%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-macosx1015-64-qr%2Fopt-mochitest-devtools-chrome-spi-nw%2Cdt1

Log: https://treeherder.mozilla.org/logviewer?job_id=406913328&repo=autoland&lineNumber=2297
https://treeherder.mozilla.org/logviewer?job_id=406914933&repo=autoland&lineNumber=2673

Backout: https://hg.mozilla.org/integration/autoland/rev/219bc96600a47cd4b95ac71b0b378db961481b33

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eacc394efd9f
[devtools] Wait for debugger frontend async work on navigation in all tests. r=devtools-reviewers,nchevobbe

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eacc394efd9f