1815552 - Deal with table cells in the abspos cb change optimization code-path

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815552 - Deal with table cells in the abspos cb change optimization code-path. r=dholbert

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52cdbb4f0be0
Deal with table cells in the abspos cb change optimization code-path. r=dholbert

Comment 3

[Marian-Vasile Laza]

Backed out changeset 52cdbb4f0be0 (Bug 1815552) for wpt failure on position-sticky-container.html.
Backout link
Push with failures <--> wpt4
Failure Log

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815552 - Make positioned table parts deal correctly with switching position without being reframed. r=TYLin

While looking at the backout, I noticed table parts relied on reframing
on abspos-container-ness changes in a subtle way, see the test, which
fails with the first patch of this bug applied without these changes.

Make the NS_FRAME_CAN_HAVE_ABSPOS_CHILDREN mean the same for table parts
as for everything else. Instead, keep the registration status on each
relevant frame class individually.

Depends on D169127

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cda1ee891058
Deal with table cells in the abspos cb change optimization code-path. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/da0f9295df91
Make positioned table parts deal correctly with switching position without being reframed. r=TYLin,layout-reviewers

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38765 for changes under testing/web-platform/tests

Comment 7

[Cristina Horotan [:chorotan]]

Backed out 2 changesets (Bug 1815552) for causing Bp-hybrid bustages at ComputedStyle.h

Backout: https://hg.mozilla.org/integration/autoland/rev/1e5f8412e406e20cf9505a8ad64fb2df063dcc17

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=da0f9295df911d66390301caf616b6fdf4880e18

Failure log: https://treeherder.mozilla.org/logviewer?job_id=407424981&repo=autoland&lineNumber=40989

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 9

[Emilio Cobos Álvarez (:emilio)]

But I had built non-unified locally :'(

Comment 10

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=6211d74b03ccc8867d6802f2692cada33e99d6de

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b3e13c4f7bc
Deal with table cells in the abspos cb change optimization code-path. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6d3ccde99ad5
Make positioned table parts deal correctly with switching position without being reframed. r=TYLin,layout-reviewers

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4b3e13c4f7bc
https://hg.mozilla.org/mozilla-central/rev/6d3ccde99ad5

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot