1815558 - Tweak nsAttrValue::Equals.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815558 - Tweak nsAttrValue::Equals(nsAtom*). r=smaug

To avoid an unconditional string copy when comparing case-insensitively
(by using nsDependentAtomString).

Since the string path is not much different than the generic code-path,
just use that elsewhere.

This shows up in selector matching.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815558 - Clean up some MiscContainer string/atom usage, and optimize atom comparison on MiscContainer. r=smaug

Not sure if you think this is worth it, it might be in some cases where
we have pre-atomized stuff in the container.

Depends on D169142

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815558 - Downgrade nsDependentString assert. r=smaug

I saw this in the nightly profile. This makes us go into the string
which in most cases is not necessary because the lengths are different.

Depends on D169143

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c044a18073a
Tweak nsAttrValue::Equals(nsAtom*). r=smaug
https://hg.mozilla.org/integration/autoland/rev/27d1755f42e0
Clean up some MiscContainer string/atom usage, and optimize atom comparison on MiscContainer. r=smaug
https://hg.mozilla.org/integration/autoland/rev/000dbf4a2b28
Downgrade nsDependentString assert. r=smaug

Comment 5

[Iulian Moraru]

Backed out changeset 27d1755f42e0 for causing multiple failures.

• Push with failures

• Backout link

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b18732bf0ec
Clean up some MiscContainer string/atom usage, and optimize atom comparison on MiscContainer. r=smaug

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4c044a18073a
https://hg.mozilla.org/mozilla-central/rev/000dbf4a2b28

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7b18732bf0ec