1815607 - Message context menu: menu items with sub-menus are slightly mis-aligned, and `Ignore Thread` etc. have negative indent of 1cm

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Right click a message. Notice the Forward and Forward As >... menus are not aligned the same. The Forward as (and others with submenu) are a few pixels more to the left than they should.

Comment 1

[Wayne Mery (:wsmwk)]

nightly 111, correct?

Comment 2

[Magnus Melin [:mkmelin]]

Yes. But I haven't checked beta.

Comment 3

[Wayne Mery (:wsmwk)]

Attachment: Screen Shot Mac.png

On Mac, pretty sure I'm not seeing this with current nightly. And I'm not seeing it with 110.0b4. I didn't test the 111.0b1 candidate.

Comment 4

[Magnus Melin [:mkmelin]]

Still there for linux daily.

Comment 5

[Thomas D. (:thomas8)]

I'm seeing this, too on Daily 112.0a1 (2023-02-19) (64-bit), Win10 - see my screenshot below.
And Ignore Thread, Ignore Subthread, and Watch Thread are totally off, with a negative indent of about 1 cm, which is about the space otherwise reserved for icons I guess.

Richard, any insights?

Comment 6

[Thomas D. (:thomas8)]

Attachment: Screenshot2: sub-menu items slightly offset to the right, and `Ignore Thread` & Co. with negative indent

Screenshot: sub-menu items slightly offset to the right, and Ignore Thread & Co. with negative indent

Comment 7

[Thomas D. (:thomas8)]

As a sidenote, it's a bit surprising why there should be so much whitespace on the left side if there's not a single icon. But if it helps to add icons later on, then so be it!

Comment 8

[Thomas D. (:thomas8)]

(In reply to Wayne Mery (:wsmwk) from comment #3)

Created attachment 9318342 [details]
Screen Shot Mac.png

On Mac, pretty sure I'm not seeing this with current nightly. And I'm not seeing it with 110.0b4. I didn't test the 111.0b1 candidate.

If that's what you're seeing on the Mac, then that's even more broken. No indication of sub-menus at all because of missing arrows on the right.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: Bug 1815607 - Don't use class="menuitem-iconic" together with type="checkbox". r=#thunderbird-front-end-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3df2a3683765
Don't use class="menuitem-iconic" together with type="checkbox". r=freaktechnik

Comment 11

[Thomas D. (:thomas8)]

Awesome! Thank you Richard!

Do you think this will also fix Wayne's Mac problem where there are no sub-menu arrows on the <menu> items?

Comment 12

[Richard Marti (:Paenglab)]

I see the arrows with and without patch. Let's wait at tomorrows Daily if Wayne sees the arrows.

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 9318764 [details]
Bug 1815607 - Don't use class="menuitem-iconic" together with type="checkbox". r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): [Supernova]
User impact if declined: not aligned menuitems
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9318764 [details]
Bug 1815607 - Don't use class="menuitem-iconic" together with type="checkbox". r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 15

[Thomas D. (:thomas8)]

Attachment: Screenshot: Favorite Folder context menu misaligned

Here's another one - Richard, would you be willing to check around in other context menus and/or regular menus?

Comment 16

[Richard Marti (:Paenglab)]

This one is fixed by my patch.

Comment 17

[Daniel Darnell [:dandarnell]]

Thunderbird 111.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/1a6a704c18d2