1815621 - Some concrete selection listeners are not notified of selection changes if there is no listeners inheriting `nsISelectionListener`

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

This is a silly regression of mine.

I made some selection listeners are concrete ones for the performance (bug 1486370, bug 1487591 and bug 1487659), but I didn't remove the early return.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

If the Selection is for a text control, TextEditor adds itself as a selection listener. Therefore, this never becomes a problem in text controls.

If the Selection is for a document, nsDocumentViewer adds its owning selection listener. I guess that this never becomes a problem in the usual normal Selection too.

According to the latter fact, we could make the latter a concrete class listener though.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

Attachment: Bug 1815621 - Make `Selection::NotifySelectionListeners` check concrete class listeners too when it wants to return early r=smaug

In bug 1486370, bug 1487591 and bug 1487659, we made Selection handle some
selection listeners with pointers to concrete classes for the performance (for
saving virtual call cost, allocation cost of the selection listener array and
copy cost of the array before notifying). However, at that time, I forgot to
change the condition of early return. Therefore, current Selection does not
notify concrete class listeners of selection changes if there is no active
nsISelectionListener instances for the Selection instance.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/203f88869b35
Make `Selection::NotifySelectionListeners` check concrete class listeners too when it wants to return early r=smaug

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/203f88869b35