1815732 - Pull to refresh activates on Twitter home

Status: RESOLVED FIXED

(Fenix :: General, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: RefreshTwitter.mp4

Issue initially reported in https://github.com/mozilla-mobile/fenix/issues/9718

Swiping up and then down to get to the top of the home feed and then overscroll can trigger the pull to refresh functionality. This is intermittent.
Testing in Fenix I see there are cases in which when we try to sync with GeckoView through InputResultDetail about how the touch was handled we can get even 10 times in a row (sometimes more, most of the time less) the following the following details here[1] based on which the app will show the pull to refresh throbber:

• inputResult == INPUT_HANDLING_UNKNOWN (-1)
• scrolLDirections == SCROLL_DIRECTIONS_NONE (0)
• overscrollDirections == OVERSCROLL_DIRECTIONS_VERTICAL (2)

Given that this issue depends on fast overscrolls I think the issue has more to do with the time APZ needs to infer the touch result.

cc Botond for recommendations since we're in an active process of polishing the feature.

 
[1] https://searchfox.org/mozilla-mobile/rev/4c640a0da38ce181ea89e71d20b90a7f881d65b9/firefox-android/android-components/components/concept/engine/src/main/java/mozilla/components/concept/engine/InputResultDetail.kt#258-261

Comment 1

[miralobontiu]

Attachment: trim.mp4

I was able to reproduce this bug on the latest Fenix Nightly 111.0a1 from 2/13 with Oppo Find X3 Lite (Android 11).

Comment 2

[Delia Pop]

This is also reproducible in Beta 111.0b4 with Sony Xperia (Android 6.0.1), LG G7 fit (Android 8.1.0) and Google Pixel 3 (Android 13).

Comment 3

[Botond Ballo [:botond]]

Based on the symptoms, this seems like the same sort of timing issue discussed in bug 1724755 comment 12, and the same solution should apply.

Comment 4

[Delia Pop]

We are able to reproduce this issue on Fenix RC 112.0 build 1, Beta 112.0b9 and Nightly 113.0a1 from 04/04 with Lenovo Yoga Tab 11 (Android 11), Sony Xperia Z5 Premium (Android 7.1.1) and Poco M4 Pro (Android 12).

Comment 5

[Delia Pop]

This issues is still reproducible in Beta 117.0b4 with Samsung Galaxy A53 5G (Android 13).

Comment 6

[miralobontiu]

We were not able to reproduce this issue on the latest Firefox for Android builds: Nightly 124, Beta 123.0b5, nor RC 122.0.1, with the following devices:

• Google Pixel 6 (Android 14),
• Samsung Galaxy A53 (Android 13),
• Samsung Galaxy A14 (Android 13), and
• Lenovo tablet M10 (Android 10).

I'll close this ticket as Resolved/Fixed.