1807071 - [Meta] Pull to refresh issues

Status: RESOLVED FIXED

(Fenix :: Browser Engine, defect, P2)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/9766.

After enabling "pull to refresh" in https://github.com/mozilla-mobile/fenix/issues/3262 a number of issues were discovered.

Most of the issues relate to the following:

• [x] No differentiation between inner / outer level scrolls.
  We should only show the throbber for top level scrolls.
  GV ticket - https://bugzilla.mozilla.org/show_bug.cgi?id=1627737

• [x] For websites with their own touch handlers but which do not consume the scroll we should allow pull to refresh.
  GV ticket - https://bugzilla.mozilla.org/show_bug.cgi?id=1633322
  Other browsers like Fennec (based on the behavior of the AwesomeBar / overscroll effect) or Chrome correctly support this.
  This needs a deeper investigation and maybe a complete rethink of how pull to refresh / dynamic toolbar works.

• [x] For websites with their own touch handlers we might show a glimpse of the throbbler.
  GV - ticket - https://bugzilla.mozilla.org/show_bug.cgi?id=1631754

• [x] No actual differentiation between zooming / scrolling gestures - https://github.com/mozilla-mobile/fenix/issues/10241

• [x] "Cancel" on a repost prompt doesn't hide the throbber - https://github.com/mozilla-mobile/fenix/issues/9799

• [x] Allow users to disable gesture based features - https://github.com/mozilla-mobile/fenix/issues/10240

• [ ] Issues with google maps' bottom sheet:

  • [x] the wrong elements scroll - fenix tracking issue | GV ticket
  • [ ] rendering issues - GV ticket
  • [ ] scroll issues - GV ticket
     

• [ ] Support more CSS and Event properties related to pull to refresh - https://bugzilla.mozilla.org/show_bug.cgi?id=1679316

• [ ] Avoid unintended refreshes - https://github.com/mozilla-mobile/fenix/issues/16577

 
As such we will disable pull to refresh until all of the above issues are resolved.
- [x] https://github.com/mozilla-mobile/fenix/issues/9770

 
With most of the issues fixed this is ready for nightly but should not get into Beta / Release until all issues are fixed.

• [x] Ticket to enable feature in Nightly/Debug - https://github.com/mozilla-mobile/fenix/pull/16060

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[tesmite]

This is a bug that has been reported for over a year and occurs on multiple sites.
https://bugzilla.mozilla.org/show_bug.cgi?id=1724755

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Not experience team work.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Tested more of the scenarios from the meta and https://github.com/mozilla-mobile/fenix/issues/9766#issuecomment-610346185 and saw that the issues from Google Maps are fixed and also the ones from Phonearena[1] and Github Notifications[2].
I also saw that two issues for Twitter and bing are still reproducing and opened new tickets for this.

 

[1] video recording showing Phonearena working as expected - https://drive.google.com/file/d/1AQtc8ZszX7pSq6PCuy_uvo7bN5azOWeX/view?usp=sharing
[2] video recording showing Github Notifications working as expected - https://drive.google.com/file/d/1PDKX5khQ7XmA_72FvT-yb5fxhjoOVH7t/view?usp=sharing

Comment 5

[Petru-Mugurel Lingurar [:petru]]

QA helped smoke test the feature and no major issues were found - https://mozilla-hub.atlassian.net/browse/QA-1759.

Comment 6

[killercontact1.7.4.0]

Attachment: bz-1807071-issues.webm

With Nightly "114.0a1 (Build #2015944675), 10dbca6e93+
GV: 114.0a1-20230413152644
AS: 97.4.1"

• Scrolling mistakenly triggers PTR (pull to refresh), mostly when scrolling fast and abruptly

• The PTR icon sometimes stays stuck on the screen in the case above, need to refresh to disappear

• Scrolling sometimes only does something to the address bar, the content itself is not scrolled

• Scrolling is stuck, stutters, combined with problems above.

Under load, with complex pages, and during stuttering, the problems worsen considerably.

Hope this bring into vision the common problems with the current implementation. If these issues are already reported and being worked on, please disregard. Thank you for your efforts.

Comment 7

[Joe M [:jmahon]]

killercontact1.7.4.0 thank you for the comment! I'm migrating your comment to its own standalone bug rather so we can track it as a bug (this metabug is just serving as a place to collect issues related to Pull to Refresh)

Comment 8

[Jonathan Almeida [:jonalmeida]]

With bug 1879583 landing based on a bunch of patches fixed for the purpose of this meta, should we move any open bugs and file new ones separately so that we can close this meta as complete?

Comment 9

[Titouan Thibaud [:titouan]]

I'll close this Meta bug as the most important parts of the work necessary to enable Pull to Refresh in Release has already been completed.
New bugs related to Pull to Refresh can be created as separate bugs.

Comment 10

[Jonathan Almeida [:jonalmeida]]

Based on comment 9 from Titouan, I am clearing cpeterson's NI and removing the remaining open bugs that are linked to this meta.

Comment 11

[Botond Ballo [:botond]]

(In reply to Titouan Thibaud [:tthibaud] from comment #9)

I'll close this Meta bug as the most important parts of the work necessary to enable Pull to Refresh in Release has already been completed.
New bugs related to Pull to Refresh can be created as separate bugs.

I found having a meta bug very useful, as being cc'ed on the meta bug allowed me to become aware of new pull-to-refresh issues as they are filed, and e.g. take a brief look at them to rule out APZ issues.

Perhaps we could open a new meta bug to use to track remaining pull-to-refresh issue?

Comment 12

[Titouan Thibaud [:titouan]]

I like the idea of a new Meta bug, I can create one. Thanks for sharing your opinion!

Comment 13

[Titouan Thibaud [:titouan]]

The current Meta we use to track the issues related to Pull to refresh is Bug 1882722