1815762 - [wmfme] Incorrect error message about `You must enable DRM to play some audio or video on this page` when trying to request information for PlayReady DRM

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Alastor Wu [:alwu]]

STR.

1. make sure media.eme.playready.enabled is false
2. go to https://testweb.playready.microsoft.com/Tool/Hwdrm
3. click Submit

Expected.
4. showing false for those results and no error pops up

Actual.
4. showing false for those results and an error You must enable DRM to play some audio or video on this page pops up

Comment 1

[Alastor Wu [:alwu]]

Attachment: bug_enable_DRM.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810817

Comment 4

[Alastor Wu [:alwu]]

Considering the merge date is close, we will need to uplift the fix to beta later after merging. John, would you mind to take a look on this bug? Thanks.

Comment 5

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1815762 - don't reture disabled status for PlayReady. r=alwu

Comment 6

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1815762 - don't return "disabled" status for PlayReady.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/453eb62ef78d
don't return "disabled" status for PlayReady. r=alwu

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The following field has been copied from a duplicate bug:

Field	Value	Source
Regressed by	bug 1815367	bug 1816244

For more information, please visit auto_nag documentation.

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/453eb62ef78d

Comment 11

[Alastor Wu [:alwu]]

Comment on attachment 9317131 [details]
Bug 1815762 - don't return "disabled" status for PlayReady.

Beta/Release Uplift Approval Request

• User impact if declined: The pop up with incorrect message would show up when users visit websites using DRM video.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We incorrect enable the DRM detection for PlayReady, and this patch will only detect PlayReady when the pref is on (off by default). This patch doesn't add any new functionality.
• String changes made/needed: No
• Is Android affected?: Unknown

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9317131 [details]
Bug 1815762 - don't return "disabled" status for PlayReady.

Approved for 111.0b1.

Comment 13

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/090e90a82979

Comment 14

[Bogdan Maris, Desktop Test Engineering]

Verified that this issue is no longer reproducible on the latest builds: 111.0b1 and 112.0a1 (latest nightly) across platforms Windows 10, macOS 13, Ubuntu 22.04.