1815851 - Import bookmarks and Bookmark toolbar items are not correctly arranged if Customize menu is opened on a new profile before the bookmark toolbar is displayed

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 111.0a1 (20230208214144)

Affected versions

• 111.0a1 (20230208214144)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 20.04
• Unaffected platforms: none

Steps to reproduce

1. Open Firefox with a new profile and open customize menu.
2. Observe the Import bookmarks and Bookmark toolbar item location.

Expected result

• They are positioned on the left side.

Actual result

• The items are positioned in the middle.

Regression range

• Last good revision: 2f9d84c464ab97221460f3a278d0bc9303cc02ec
  First bad revision: cea865489ae710d914662d28b072f0ef604df673
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2f9d84c464ab97221460f3a278d0bc9303cc02ec&tochange=cea865489ae710d914662d28b072f0ef604df673

Additional notes

• Attached a screenshot.
• This issue is reproducible only on a new profile and if the Customize menu is opened before the bookmark toolbar is displayed (e.g if a new tab is opened on a new profile and the bookmark toolbar is displayed the issue is no longer reproducible.)
• After restart the issue cand be seen again until the bookmarks toolbar is displayed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1812636, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815851 - Allow to hide the empty bookmarks message when customizing regardless of initialization status. r=Gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0d712e45af5
Allow to hide the empty bookmarks message when customizing regardless of initialization status. r=Gijs

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a0d712e45af5

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 110.0a1 (20230212085204) on Windows 10x64, macOS 12 and Ubuntu 20.04. The Import bookmarks and Bookmark toolbar items are positioned on the left side as expected after following the steps from comment 0.