1812636 - "Manage bookmarks" link on empty bookmarks toolbar has stopped working for clicks (but works when doubleclicked), only on Windows

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[:Gijs (he/him)]

STR:

1. clean profile, Win10, open Firefox
2. remove "getting started" bookmark using the context menu
3. remove "import bookmarks" button using the context menu
4. try clicking the "Manage bookmarks..." link

ER:

it opens the library

AR:

it does not.

Double-clicking opens the window, but that makes even less sense. I don't know why the single click is getting eaten and the double-click isn't. I'm fairly sure this is a regression but haven't yet tried to figure out when it broke. It still works fine on macOS.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ff88d45f59c4357dcc71ddf4ad5344a38f9944d&tochange=aa325161aae5e555cab4d44b6662bbe029d26a5d

Comment 2

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #1)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ff88d45f59c4357dcc71ddf4ad5344a38f9944d&tochange=aa325161aae5e555cab4d44b6662bbe029d26a5d

Thanks Alice!

Emilio, another thing that hopefully just takes removing some silly code to fix? 😉

Potentially relevant: bug 1680762.

Comment 3

[Alice0775 White]

#personal-toolbar-empty-description { min-width:100vw; } seems fix this.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790616

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1812636 - Fix empty bookmarks toolbar message width with flexbox emulation. r=Gijs

The width: 0 was never honored and acted like min-width: 0 effectively.

The issues that they supposedly fixed still work with this change, I'm
confused about why so much CSS is needed for this message.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot of "good" build.

Ok, so I dug a bit more, and what happens is that, given the description is width: 0 and now we actually honor it, this line doesn't add the area of the link and message to the no-drag region. And since it's part of the drag region the OS eats the click.

So, pretty sure the patch as submitted is correct. width: 0 wasn't getting honored and the description ended up being the width of all its contents (so behavior was like min-width: 0 with modern flexbox). Does that make you happier about the patch?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cea865489ae7
Fix empty bookmarks toolbar message width with flexbox emulation. r=Gijs

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cea865489ae7

Comment 9

[Pascal Chevrel:pascalc]

Emilio, do we want to take it into the dot release? Thanks

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9314364 [details]
Bug 1812636 - Fix empty bookmarks toolbar message width with flexbox emulation. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner
• String changes made/needed: none
• Is Android affected?: Yes

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9314364 [details]
Bug 1812636 - Fix empty bookmarks toolbar message width with flexbox emulation. r=Gijs

Approved for planned dot release 110.0.1
Thanks

Comment 12

[Catalin Sasca, Desktop QA [:csasca]]

Reproduced the issue on Firefox 111.0a1 (2023-01-26) on Windows 10 by following the STR provided in Comment 0.

The issue is fixed on Firefox 111.0b6 and Firefox 112.0a1 (2023-02-26) on the same system.

Comment 13

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/1b449540ffa5

Comment 14

[Catalin Sasca, Desktop QA [:csasca]]

Verified that the fix is working as expected on Firefox 110.0.1-build2 on the same system.

Comment 15

[Donal Meehan [:dmeehan]]

Backed out of 111 Beta for introducing Bug 1819980
https://hg.mozilla.org/releases/mozilla-beta/rev/d46c8d2990d6