1815865 - Intervention card button is barely readable on hover with Dark Theme enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Ardelean Oana, Desktop QA [:oardelean]]

Attachment: Screenshot 2023-02-09 at 12.34.10.png

Found in

• Nightly 111.0a1

Affected versions

• Nightly 111.0a1

Tested platforms

• macOS 12
• Windows 10
• Ubuntu 22

Affected platforms

• macOS 12
• Windows 10
• Ubuntu 22

Unaffected platforms

• N/A

Steps to reproduce

1. Launch Nightly.
2. Go to about:addons and change to Dark Theme.
3. In a new tab, trigger an Intervention Card(eg. type 'refresh firefox', 'cache firefox' in the Address Bar)
4. Hover over the 'Refresh Firefox' button.

Expected result

• Hover highlights properly and the text is readable.

Actual result

• Hover makes the text barely readable.

Regression range

• First bad: 2023-02-08
• Last good: 2023-02-07
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=602aa16c20d47216f2e4a3b8877c3e34ca947f33&tochange=d271704f07ad34f25bea298c69e6c02cbcf6bea8
• Potentially regressed by: bug 1815423

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1815423

:dao, since you are the author of the regressor, bug 1815423, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1815865 - Align tip buttons more closely with other view buttons. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f02cc7328d9e
Align tip buttons more closely with other view buttons. r=adw

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f02cc7328d9e

Comment 5

[Ardelean Oana, Desktop QA [:oardelean]]

Reproduced on a 2023-02-09 Nightly build on macOS 12.
Verified as fixed on Nightly 112.0a1(build ID: 20230214093302) on macOS 12, Ubuntu 22, Windows 10.