Closed Bug 181589 Opened 17 years ago Closed 16 years ago
Add mass-group-edits to editgroups
To assist admins with sites moving from old (2.16 and prior) groups to the new implicit groups where regexps are continuously applieed, editgroups needs some new functions. 1) Remove all explicit memberships from this group 2) Remove all explicit memberships who are covered by the regexp from this group Naturally, both of these need a very serious confirm screen.
despite this really being an enhancement, I'm setting the severity on this to blocker. I will not call Bugzilla "version 2.18" without this feature.
Severity: enhancement → blocker
Priority: P3 → P1
Dave: your last comment implies that this is really important. Do we need it for the b.m.o. upgrade? Gerv
b.m.o won't need it. But I'll still hold the blocker status for 2.18.
just to point out to any involved parties, this is still a 2.18 blocker. (2.18 is coming up rather soon now)
I have been short on time lately. I won't minf if someone wants to work on this.
To unblock 2.18..... How about doing this with a hyperlink near the regexp in the editgroups UI. The hyperlink would be "<a>remove</a> users matching this expression from the group (they will still have access so long as they continue to match this expression)" If clicked, it would bring up a confirm screen. It's not the prettiest approach, but it would work.
Removing dependancy on 190222 (templatize editgroups.cgi), we need this bug for 2.18 and 190222 isn't targetted until 2.20. We will just have to roll these changes into the template version.
No longer depends on: 190222
This patch adds the UI to editgroups.cgi and adds a confirmation screen too. There's a small bug elsewhere in editgroups.cgi that is fixed as well (proper html quoting of a hidden form field). Hooks are in place (marked with "# JOEL: HERE") for the actual group removal logic to be added.
In looking at this patch. Maybe the Remove Explicit Members in the Regular Expression button should be removed if the regex field is empty. When I click on the button when the field is empty, I get in the next screen, This option will remove all users included in the regular expression: from group foo.
Maybe this is best done from a page that doesn't let you edit the regexp? Like the main group list page when you initially go to editgroups.cgi?
OK, confirm screen handles case of empty regexp
Attachment #144447 - Attachment is obsolete: true
I can't review this as I don't understand groups... but my comment is that I also don't understand the need for it or what it does from the text in the .cgi. I suggest that either documentation or more explanation are probably required... Gerv
justdave: I think this would be pretty confusing to have on the main editgroup page, since it specifically edits a single group, not all of them at once.
maybe it should prompt you for a group to remove people from after you choose it then. Or maybe the text around the link on the group edit page should state in the text which regexp will be used for the removal...
The current patch already does use the new regexp. It is implemented as a submit button. The confirm page already does show the regexp that is about to be used.
Shows who is being removed
Attachment #144578 - Attachment is obsolete: true
Attachment #144843 - Flags: review?(justdave) → review+
This needs documentation and good coverage in the upgrading section of the release notes.
Checking in editgroups.cgi; /cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v <-- editgroups.cgi new revision: 1.32; previous revision: 1.31 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Documentation: tip: Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 1.55; previous revision: 1.54 done 2.20: Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 126.96.36.199; previous revision: 188.8.131.52 done 2.18.4: Checking in docs/xml/administration.xml; /cvsroot/mozilla/webtools/bugzilla/docs/xml/administration.xml,v <-- administration.xml new revision: 184.108.40.206; previous revision: 220.127.116.11 done
You need to log in before you can comment on or make changes to this bug.