1815898 - Remove built-in colorways and inform their remaining users about colorways on AMO

Status: RESOLVED FIXED

(Firefox :: Theme, task)

Description

[Dão Gottwald [:dao]]

As we roll out bug 1808589, we'll want to stop shipping built-in colorways sometime soon.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1815898 - Inform users about Colorway theme removal - part 1 - notification bar, r?dao

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1815898 - Inform users about Colorway theme removal - part 2 - about:addons, r?dao

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1815898 - Inform users about Colorway theme removal - part 3 - remove colorways themes, r?dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9d76f720e1a
Inform users about Colorway theme removal - part 1 - notification bar, r=fluent-reviewers,bolsson,rpl
https://hg.mozilla.org/integration/autoland/rev/642ddfbde81f
Inform users about Colorway theme removal - part 2 - about:addons, r=fluent-reviewers,bolsson,rpl
https://hg.mozilla.org/integration/autoland/rev/dc30f3911c99
Inform users about Colorway theme removal - part 3 - remove colorways themes, r=dao,desktop-theme-reviewers,emilio,rpl

Comment 5

[agoloman]

Backed out for causing bc failures @browser_BuiltInThemes_installs.js.

• Backout link
• Push with failures
• Failure Log

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hey Andrea, it looks like the reason for the browser_BuiltInThemes_installs.js failure is just the fact that the test setup callback was stubbing with sinon a method that the part 3 patch is removing, removing that sinon stub seems to be enough to fix that failure, the following is the diff I applied locally to make the test to pass:

diff --git a/browser/themes/test/browser/browser_BuiltInThemes_installs.js b/browser/themes/test/browser/browser_BuiltInThemes_installs.js
--- a/browser/themes/test/browser/browser_BuiltInThemes_installs.js
+++ b/browser/themes/test/browser/browser_BuiltInThemes_installs.js
@@ -29,10 +29,6 @@ add_setup(() => {
       info(`Got AddonManager.maybeInstallBuiltinAddon call: ${args}`);
       maybeInstallBuiltinAddonCallArgs.push(args);
     });
-
-  // Stub BuiltInThemes method called from ensureBuiltInThemes to
-  // make it a no-op.
-  sandbox.stub(Object.getPrototypeOf(BuiltInThemes), "_uninstallExpiredThemes");
 });
 
 add_task(async function test_maybeInstallActiveBuiltInTheme() {

would you mind to roll that into part 3 patch?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6571fe9eb73
Inform users about Colorway theme removal - part 1 - notification bar, r=fluent-reviewers,bolsson,rpl
https://hg.mozilla.org/integration/autoland/rev/764d7b27fa86
Inform users about Colorway theme removal - part 2 - about:addons, r=fluent-reviewers,bolsson,rpl
https://hg.mozilla.org/integration/autoland/rev/8c5612805e02
Inform users about Colorway theme removal - part 3 - remove colorways themes, r=dao,desktop-theme-reviewers,emilio,rpl

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b6571fe9eb73
https://hg.mozilla.org/mozilla-central/rev/764d7b27fa86
https://hg.mozilla.org/mozilla-central/rev/8c5612805e02

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we wanted to call out in the Fx139 relnotes?

Comment 10

[Andrea Marchesini [:baku]]

No. We already migrated users to the AMO colorway themes. This is just the final cleanup.