1830337 - Consider to allow builtin colorways pending updates to be applied also when auto-updates are disabled for other add-ons

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As part of allowing clients with a colorway builtin theme set to keep the colorway theme when we will remove them from the Gecko builds, we need to account that some clients may have extensions.update.autoUpdateDefault set to false, in which case Gecko still checks for add-on updates in the background but the updates found will be kept pending until the user will explicitly apply them (unlike extensions.update.enabled which would disable also checking for updates).

The users are not being notified when an add-on update has been found in the background and so the users would not be aware of the pending update unless the about:addons tab is explicitly open.

This bug is tracking considering to special case pending updates specifically for the colorway builtin theme being migrated (and instead keep the current expected behavior for any other add-on, included colorway theme that have been migrated to the AMO-hosted xpi file and installed in the user profile).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1830337 - Allow builtin colorways pending updates to be applied also when auto-updates are disabled for other add-ons. r?willdurand!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rpl, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f57e657f378
Allow builtin colorways pending updates to be applied also when auto-updates are disabled for other add-ons. r=willdurand

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2f57e657f378

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Release Note Request (optional, but appreciated)
[Why is this notable]:

• To preserve the user choice related to the colorway builtin theme selected, in Firefox 115 we will be exempting the colorway builtin update (converting the builtin into a profile installed theme) from honoring the extensions.update.autoUpdateDefault pref when set to false (which prevents addons updates found from being auto-applied and keeps them pending)
• without this change, when the colorways builtin themes will be removed from the Firefox builds, the users with extensions.update.autoUpdateDefault pref set to false would lose their colorway theme and be switched automatically to the default theme.
  [Affects Firefox for Android]: No

[Suggested wording]: To prevent user data loss, retained Firefox Colorways built-in themes will be automatically migrated to the same Colorways themes hosted on addons.mozilla.org for Firefox profiles that have add-ons auto-updates disabled.
[Links (documentation, blog post, etc)]: No

Comment 6

[Donal Meehan [:dmeehan]]

:luca thanks for the nomination, could you give me some suggested wording for this? Something I can start from to create a release note.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Donal Meehan [:dmeehan] from comment #6)

:luca thanks for the nomination, could you give me some suggested wording for this? Something I can start from to create a release note.

I have just updated comment 5 with some suggested wording.

Comment 8

[Donal Meehan [:dmeehan]]

Thanks, added a slightly reworded note to the Nightly release notes. Keeping the relnote? flag open to keep it on the radar for inclusion in our final release notes.