1816004 - Remove unused feature flags from code base

Status: RESOLVED FIXED

(Firefox for Android :: General, task, P3)

Description

[Jonathan Almeida [:jonalmeida]]

These are two flags that we know we don't need that the engineering team has verified we can remove:

• wallpaperV2Enabled
• saveToPDF

Comment 1

[Jonathan Almeida [:jonalmeida]]

Happy to mentor anyone that wants to pick-up this bug. Please need-info me accordingly.

Comment 2

[milena.rosa]

Hi, could I help with this one?

Comment 3

[Jonathan Almeida [:jonalmeida]]

Hello! Sure thing - as mentioned above, we have those two feature flags that live in the FeatureFlags.kt file. We want to remove those and any references to those flags. If you see those flags used in if-else conditions, we want to only keep the true case.

Github has some good documentation on how to create a pull request at the firefox-android project. If you haven't already, install Android Studio and import the fenix/ directory into Android Studio to setup the project.

Try to build Fenix and install it on an emulator or a test device first before attempting to write a patch.

Let me know if anything is unclear or you need more help. We're also active in the Fenix matrix channel if you'd like more real-time responses: https://matrix.to/#/#fenix:mozilla.org

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] bug 1816004:removed 'wallpaperV2Enabled' and 'saveToPDF' flags. (#1796)

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1816004 - Remove unused feature flags from code base (#1797)

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1816004 - Removed unused feature flags (#1799)

Comment 7

[milena.rosa]

Hi! Thanks for the quick answer!
I've opened a PR. I saw it opens an automation here. So, should I do something more after opening it?
Thus, when creating the PR, a "This branch is out-of-date with the base branch" message was shown. Should I act about it? If this is the case, should I use merge or rebase for that?

[so many questions... have to start somewhere... ;) ]

Comment 8

[jackyzy823]

Hello, I'm not a Mozilla developer but willing to help.

(In reply to milena.rosa from comment #7)

Hi! Thanks for the quick answer!
I've opened a PR. I saw it opens an automation here. So, should I do something more after opening it?

Nothing to do here except that you can ping/notify the reviewer.

However you should pay attention to if your pull requests pass the checks. It looks like your PR failed to pass the check , because you may forget to remove unused imports.
See https://github.com/mozilla-mobile/firefox-android/pull/1799/checks?check_run_id=13054242476

[task 2023-04-26T23:36:38.775Z] /builds/worker/checkouts/vcs/fenix/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt:27:1: Unused import (no-unused-imports)
[task 2023-04-26T23:36:39.075Z] /builds/worker/checkouts/vcs/fenix/app/src/main/java/org/mozilla/fenix/wallpapers/WallpapersUseCases.kt:15:1: Unused import (no-unused-imports)
[task 2023-04-26T23:36:40.575Z] /builds/worker/checkouts/vcs/fenix/app/src/main/java/org/mozilla/fenix/settings/wallpaper/WallpaperSettingsFragment.kt:22:1: Unused import (no-unused-imports)

Thus, when creating the PR, a "This branch is out-of-date with the base branch" message was shown. Should I act about it? If this is the case, should I use merge or rebase for that?

Basically, If there's no conflict with the branch you want to merge , you could do nothing. If you're willing to do something ,you could rebase your branch with the branch you want to merge.

However you'd better following Mozilla developers' guide and advice.

[so many questions... have to start somewhere... ;) ]

Comment 9

[Jonathan Almeida [:jonalmeida]]

Thanks jackyzy823!

Nothing to do here except that you can ping/notify the reviewer.

Indeed, please use the "needinfo" flag to alert someone if you are looking for feedback or response on your patch.

milena.rose, happy to help more as well if the feedback above is unclear. :)

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1816004 - Remove unused saveToPDF feature flags (#2394)

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1816004 - Remove unused unifiedSearchFeature and notificationPrePermissionPromptEnabled feature flags (#2395)

Comment 12

[BMO Github Automation]

Authored by https://github.com/milena-rosa
https://github.com/mozilla-mobile/firefox-android/commit/6e53ac4968c8a42263f55142448e19cc8f398301
[main] Bug 1816004 - Remove unused saveToPDF feature flags

Comment 13

[BMO Github Automation]

Authored by https://github.com/gabrielluong
https://github.com/mozilla-mobile/firefox-android/commit/2dee46be18d91da5697e51516ad38efc2643c678
[main] Bug 1816004 - Remove unused unifiedSearchFeature and notificationPrePermissionPromptEnabled feature flags