1816266 - comm/mail/moz.comfigure cleanup

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

There's a few things in mail/moz.configure that need cleanup.

MOZ_SEPARATE_MANIFEST_FOR_THEME_OVERRIDES for sure.

I'd like to nuke all of the commtopsrcdir moztopsrcdir stuff.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove theme override define from mail/moz.configure. r=#thunderbird-build-system-reviewers

Bug 1372694 removed "heavy weight" theme support upstream, this define no longer
serves any purpose.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove install.rdf for old-style langpacks. r=#thunderbird-build-system-reviewers

Bug 1395363 switched langpacks over to be webextensions, this file is no longer
used.

Depends on D169557

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove install.rdf from themes directory. r=#thunderbird-build-system-reviewers

Unclear when the need for this file went away, but it can go.

Depends on D169558

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove THUNDERBIRD_VERSION configure variables. r=#thunderbird-build-system-reviewers

THUNDERBIRD_VERSION_DISPLAY was only used on about:buildconfig, and it's been
broken for some time, always displaying "unknown" instead of the actual version.

Depends on D169559

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove parent directory traversals (../) from manifest files. r=#thunderbird-front-end-reviewers

There's no need for things like "../../../browser" to get to parent paths,
starting the source path with a "/" will start at $topsrcdir.

Depends on D169560

Comment 6

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove "%s" replacements from moz.build files. r=#thunderbird-build-system-reviewers

Most cases of using "%s" in path-related values are to find $topsrcdir. In
moz.build files, paths starting with "/" are rooted at $topsrcdir, so a string
replacement like "/%s/browser" % CONFIG["mozreltopsrcdir"] evaluates to
"/./browser", which is just unnecessary.

Depends on D169561

Comment 7

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove mailnews/mailnews.mozbuild file. r=#thunderbird-build-system-reviewers

This is a useless file tha only adds /comm/mailnews to the directories to build,
which can be accomplished just as easily from mail/app.mozbuild.

Depends on D169562

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove use of $(moztopsrcdir) and friends from Makefiles. r=#thunderbird-build-system-reviewers

$moztopsrcdir is always the same as $topsrcdir. This is a leftover from when
it was posssible to build Thunderbird with comm-central as a parent of
mozilla-central in the local filesystem. It's just confusing to have now.

Depends on D169563

Comment 9

[Rob Lemley [:rjl]]

Attachment: Bug 1816266 - Remove (moz|comm)(rel)?top(src|obj)dir from configure files. r=#thunderbird-build-system-reviewers

The only one of these left in use is commtopsrcdir. While not strictly needed,
it is used in m-c code in a few places to detect a Thunderbird build environment.
Without a decent replacement, keep commtopsrcdir around.

Depends on D169564

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8845921e8905
Remove theme override define from mail/moz.configure. r=dandarnell
https://hg.mozilla.org/comm-central/rev/4afcbe98221f
Remove install.rdf for old-style langpacks. r=dandarnell
https://hg.mozilla.org/comm-central/rev/c7d0f59ecc32
Remove install.rdf from themes directory. r=dandarnell
https://hg.mozilla.org/comm-central/rev/cc79a4204e18
Remove THUNDERBIRD_VERSION configure variables. r=dandarnell
https://hg.mozilla.org/comm-central/rev/44eb37b7f6b9
Remove parent directory traversals (../) from manifest files. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/8fe81e869eff
Remove "%s" replacements from moz.build files. r=dandarnell
https://hg.mozilla.org/comm-central/rev/c9406a855873
Remove mailnews/mailnews.mozbuild file. r=dandarnell
https://hg.mozilla.org/comm-central/rev/61053a4fc27c
Remove use of $(moztopsrcdir) and friends from Makefiles. r=dandarnell
https://hg.mozilla.org/comm-central/rev/453e6e09baa1
Remove (moz|comm)(rel)?top(src|obj)dir from configure files. r=dandarnell