1816756 - Several `uncaught exception: unknown (can't convert to string)` errors are logged after closing PiP for videos using site-specific wrappers

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[kpatenio]

STR:

1. Watch a YT video (example)
2. Turn on cc on video
3. Enable PiP for video using toggle
4. Close opened PiP window
5. Observe how error is logged every time cc updates on video, even if PiP window is closed

Full log:

uncaught exception: unknown (can't convert to string) youtube.js:42:33
    callback moz-extension://27b7d8dc-2525-4219-a4bd-45122c6314b9/video-wrappers/youtube.js:42
    (Async: MutationCallback)
    setCaptionContainerObserver moz-extension://27b7d8dc-2525-4219-a4bd-45122c6314b9/video-wrappers/youtube.js:57
    #callWrapperMethod resource://gre/actors/PictureInPictureChild.sys.mjs:2442
    setCaptionContainerObserver resource://gre/actors/PictureInPictureChild.sys.mjs:2802
    setUpCaptionChangeListener resource://gre/actors/PictureInPictureChild.sys.mjs:1976
    setupTextTracks resource://gre/actors/PictureInPictureChild.sys.mjs:1386
    trackOriginatingVideo resource://gre/actors/PictureInPictureChild.sys.mjs:1957
    setupPlayer resource://gre/actors/PictureInPictureChild.sys.mjs:2103
    InterpretGeneratorResume self-hosted:1960
    AsyncFunctionNext self-hosted:948
    (Async: async)
    receiveMessage resource://gre/actors/PictureInPictureChild.sys.mjs:1802
    (Async: JSActor query)
    init chrome://global/content/pictureinpicture/player.js:191
    setupPlayer chrome://global/content/pictureinpicture/player.js:58
    handlePictureInPictureRequest resource://gre/modules/PictureInPicture.sys.mjs:432
    AsyncFunctionNext self-hosted:948
    (Async: async)
    receiveMessage resource://gre/modules/PictureInPicture.sys.mjs:53
    (Async: JSActor query)
    togglePictureInPicture resource://gre/actors/PictureInPictureChild.sys.mjs:193
    handleEvent resource://gre/actors/PictureInPictureChild.sys.mjs:119
    startPictureInPicture resource://gre/actors/PictureInPictureChild.sys.mjs:843
    onPointerDown resource://gre/actors/PictureInPictureChild.sys.mjs:813
    handleEvent resource://gre/actors/PictureInPictureChild.sys.mjs:464
    (Async: EventListener.handleEvent)
    addMouseButtonListeners resource://gre/actors/PictureInPictureChild.sys.mjs:588
    beginTrackingMouseOverVideos resource://gre/actors/PictureInPictureChild.sys.mjs:671
    onIntersection resource://gre/actors/PictureInPictureChild.sys.mjs:565
    (Async: requestIdleCallback handler)
    onIntersection resource://gre/actors/PictureInPictureChild.sys.mjs:564
    onIntersection self-hosted:1497
    (Async: IntersectionCallback)
    registerVideo resource://gre/actors/PictureInPictureChild.sys.mjs:492
    handleEvent resource://gre/actors/PictureInPictureChild.sys.mjs:433
    Le https://www.youtube.com/s/player/d405f6b4/player_ias.vflset/en_US/base.js:393
    tZ https://www.youtube.com/s/player/d405f6b4/player_ias.vflset/en_US/base.js:5925
    DYa https://www.youtube.com/s/player/d405f6b4/player_ias.vflset/en_US/base.js:5940
    rZ https://www.youtube.com/s/player/d405f6b4/player_ias.vflset/en_US/base.js:5912
    create https://www.youtube.com/s/player/d405f6b4/player_ias.vflset/en_US/base.js:10935
    playerBootstrap https://www.youtube.com/watch?v=fbJI-si5BKQ:65
    <anonymous> https://www.youtube.com/watch?v=fbJI-si5BKQ:66

Additional notes:

• tested on MacOS Monterey 12.5.1

Comment 1

[kpatenio]

From the comments in Bug 1845759, it appears that the issue can occur for any site-specific wrapper. Perhaps we should clean up the observers used to set up our PiP wrappers whenever we close the PiP window.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1816756 - Add removeCaptionContainerObserver method for PictureInPictureChildVideoWrapper. r=#pip-reviewers

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1816756 - Add removeCaptionContainerObserver to all site wrappers. r=#pip-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/109e09162a0c
Add removeCaptionContainerObserver method for PictureInPictureChildVideoWrapper. r=pip-reviewers,mconley
https://hg.mozilla.org/integration/autoland/rev/66bdc2f3e8f0
Add removeCaptionContainerObserver to all site wrappers. r=pip-reviewers,mconley

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/109e09162a0c
https://hg.mozilla.org/mozilla-central/rev/66bdc2f3e8f0