1816814 - Go | Back or Forward - [ and ] keys - message navigation do not work.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

cmd_goBack go back and cmd_goForward - buttons missing and commands (using the Go menu) not working: there are exception in console

Comment 1

[Wayne Mery (:wsmwk)]

This is working for me using current nightly, via menu and customized unified toolbar.

Thomas, what do you see?

Comment 2

[Thomas D. (:thomas8)]

Back and Forward buttons are missing from unified toolbar customization (different from Previous and Next).
cmd_goBack go back and cmd_goForward from main menu fail with error on 112.0a1 (2023-02-27) (64-bit), Win10.

STR

• Select msg A, then msg B (non-adjacent for best understanding)
• Main menu: Go > Back (Forward by analogy)

Actual

• Nothing
• Console error:

  An error occurred executing the cmd_goBack command: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBView.viewNavigate]" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://messenger/content/mailCommon.js :: _navigate :: line 576" data: no] globalOverlay.js:103:13

Expected

• add Back and Forward buttons to UTB customization (bug 1815489)
• make the commands work again: no console error
• go back/forward along the messages in the order as selected by user ("message reading history"). Per STR above, go back to msg A.

Comment 3

[Wayne Mery (:wsmwk)]

Ah yes, I was using prev and next.

Comment 4

[Wayne Mery (:wsmwk)]

do we need both this and bug 1815489 ?

Comment 5

[Magnus Melin [:mkmelin]]

I think so, that is just about the buttons. They certainly are quite related of course.

Comment 6

[Martin Giger [:freaktechnik]]

Attachment: Bug 1816814 - Reimplement message history for go forward/back commands. r=darktrojan

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1816814 - Remove nsMessenger message history implementation. r=darktrojan

Depends on D172464

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b5481be01626
Reimplement message history for go forward/back commands. r=darktrojan
https://hg.mozilla.org/comm-central/rev/780f56cf58b0
Remove nsMessenger message history implementation. r=darktrojan

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9322810 [details]
Bug 1816814 - Remove nsMessenger message history implementation. r=darktrojan

[Triage Comment]
Approved for beta

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9322808 [details]
Bug 1816814 - Reimplement message history for go forward/back commands. r=darktrojan

[Triage Comment]
Approved for beta

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 112.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/6f9f0c4d2658
https://hg.mozilla.org/releases/comm-beta/rev/9e9a4380a487